Skip to content

[lldpmgrd] Fix potential race condition when interfaces are created#1469

Merged
jleveque merged 4 commits intosonic-net:masterfrom
jleveque:lldpmgrd_race_cond_fix
Mar 8, 2018
Merged

[lldpmgrd] Fix potential race condition when interfaces are created#1469
jleveque merged 4 commits intosonic-net:masterfrom
jleveque:lldpmgrd_race_cond_fix

Conversation

@jleveque
Copy link
Contributor

@jleveque jleveque commented Mar 7, 2018

- What I did

  • Patch lldpctl/lldpcli so that it returns an error code if specified port doesn't exist
    • Removed lldpd submodule; now cloning source repo and applying patch during build
  • Add retry logic to lldpmgrd so that it will continually retry lldpcli commands which return an error code
  • Cause swsscommon select() call to timeout after 10 seconds in order to periodically force a retry of any queued-up (i.e., previously failed) commands.

@jleveque jleveque self-assigned this Mar 7, 2018
@jleveque jleveque requested a review from lguohan March 7, 2018 20:01
@jleveque jleveque merged commit c161de4 into sonic-net:master Mar 8, 2018
@jleveque jleveque deleted the lldpmgrd_race_cond_fix branch March 8, 2018 01:08
@stcheng
Copy link
Contributor

stcheng commented Mar 8, 2018

💯

@jleveque jleveque mentioned this pull request Aug 24, 2018
Closed
@daall daall mentioned this pull request Oct 26, 2020
Merged
3 tasks
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Mar 4, 2021
@yxieca
[202012][swss][utilities] advance submodule head
bcca2a5 
swss:
* c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) (HEAD -> 202012) [Prince Sunny]

utilities:
* 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) (HEAD -> 202012) [Danny Allen]
* d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) [Junchao-Mellanox]
* a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) [Danny Allen]
* bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) [Lawrence Lee]

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca mentioned this pull request Mar 4, 2021
Merged
yxieca added a commit that referenced this pull request Mar 5, 2021
@yxieca
[202012][swss][utilities] advance submodule head (#6969)
30e9f02 
swss:
* c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) (HEAD -> 202012) [Prince Sunny]

utilities:
* 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) (HEAD -> 202012) [Danny Allen]
* d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) [Junchao-Mellanox]
* a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (#1469) [Danny Allen]
* bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) [Lawrence Lee]

Signed-off-by: Ying Xie <[email protected]>
@vdahiya12 vdahiya12 mentioned this pull request Mar 9, 2021
Merged
4 tasks
vdahiya12 added a commit that referenced this pull request Mar 10, 2021
@vdahiya12
[sonic-utilities] submodule update (#6992)
ddf51c7 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460)
e32b5ac Add soft-reboot reboot type (#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (#1416)
79ccd03 [show] cli support for show muxcable cableinfo (#1448)

Signed-off-by: vaibhav-dahiya <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@daall
[acl-loader] Add support for matching on ICMP and VLAN info (sonic-ne…
38c8e00 
…t#1469)

- Add ICMP and VLAN fields
- Add new unit test cases

Signed-off-by: Danny Allen <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@vdahiya12 @raphaelt-nvidia
[sonic-utilities] submodule update (sonic-net#6992)
433a4f4 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@vdahiya12
[sonic-utilities] submodule update (sonic-net#6992)
7463823 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@qiluo-msft
Add missing lib for lgtm (sonic-net#1469)
f2ad8f6
mssonicbld added a commit that referenced this pull request Nov 23, 2024
@mssonicbld
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
b013243 
…tically (#20835)

#### Why I did it
src/sonic-sairedis
```
* e6ec1424 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Add attribute version check feature (#1470) (14 hours ago) [Kamil Cudnik]
* 29a8f86b - [meta] Use metadata to check port notification port_id type (#1469) (2 days ago) [Kamil Cudnik]
* d772864e - innovium rename to marvell-teralynx (#1408) (2 days ago) [krismarvell]
* 526bca31 - [submodule] Update SAI to lates origin master (#1466) (2 days ago) [Kamil Cudnik]
* fc376d50 - [test] Add more testing for NotificationSwitchAsicSdkHealthEvent (#1463) (4 days ago) [Kamil Cudnik]
* ed222eca - [submodule] Update SAI to v1.15.1 (#1462) (5 days ago) [Kamil Cudnik]
```
#### How I did it
#### How to verify it
#### Description for the changelog
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
@mssonicbld @VladimirKuk
[submodule] Update submodule sonic-sairedis to the latest HEAD automa…
4a2560f 
…tically (sonic-net#20835)

#### Why I did it
src/sonic-sairedis
```
* e6ec1424 - (HEAD -> master, origin/master, origin/HEAD) [syncd] Add attribute version check feature (sonic-net#1470) (14 hours ago) [Kamil Cudnik]
* 29a8f86b - [meta] Use metadata to check port notification port_id type (sonic-net#1469) (2 days ago) [Kamil Cudnik]
* d772864e - innovium rename to marvell-teralynx (sonic-net#1408) (2 days ago) [krismarvell]
* 526bca31 - [submodule] Update SAI to lates origin master (sonic-net#1466) (2 days ago) [Kamil Cudnik]
* fc376d50 - [test] Add more testing for NotificationSwitchAsicSdkHealthEvent (sonic-net#1463) (4 days ago) [Kamil Cudnik]
* ed222eca - [submodule] Update SAI to v1.15.1 (sonic-net#1462) (5 days ago) [Kamil Cudnik]
```
#### How I did it
#### How to verify it
#### Description for the changelog
patrickmacarthur added a commit to patrickmacarthur/sonic-buildimage that referenced this pull request Dec 11, 2025
@patrickmacarthur @arlakshm
[Arista] [msft-202405] Update platform library modules (sonic-net#1469)
0db75d2 
<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

- Modify LC reboot cause on ungraceful supervisor reboot
- Improve LC reboot cause when chassis is powercycled

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it

Bumped the platform submodules.

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

Boot an Arista chassis with the image and verify that the image boots.

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)

Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels

Bug 🐛 Enhancement ➕

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jleveque @stcheng @lguohan