[installer]: support new onie machine.conf format#1468
Merged
lguohan merged 2 commits intosonic-net:masterfrom Mar 18, 2018
Merged
[installer]: support new onie machine.conf format#1468lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Mar 7, 2018
installer/x86_64/install.sh
Outdated
Collaborator
There was a problem hiding this comment.
Why use 'set' instead of 'env'?
Suggest grep 'onie_' at the line beginning. Maybe
env | grep ^onie_
Not sure it is available in ONIE environment.
Collaborator
Author
There was a problem hiding this comment.
since the variables are not exported, so they are not env
onie_* variable are generated at runtime in /etc/machine.conf. We can no longer copy the static machine.conf into sonic image.
Signed-off-by: Guohan Lu <[email protected]>
|
/host/machine.conf is incorrent for other application. Please remove quote. |
abdosi
added a commit
that referenced
this pull request
Mar 7, 2021
9e740759c370645b4367acf22856aebcfb7fce45 (HEAD -> 201911, origin/201911) [201911][multi asic] show ip bgp summary changes for bgp mon (#1483) fa07245786df11e6df902c33fcd9c7115a7c5380 [CLI][techsupport] Merge 'show techsupport' changes from master (#1468) Signed-off-by: Abhishek Dosi <[email protected]>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
mssonicbld
added a commit
that referenced
this pull request
Dec 11, 2024
…tically (#21001) #### Why I did it src/sonic-sairedis ``` * e7dc0d2b - (HEAD -> 202405, origin/202405) [202405] Fix compilation error on Buster (#1483) (18 hours ago) [Junchao-Mellanox] * 06d34610 - Support SAI_QUEUE_ATTR_TYPE on vs platform simulating MLNX2700 (#1459) (6 days ago) [Stephen Sun] * 0bd015e3 - Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option (#1437) (8 days ago) [Stephen Sun] * 497bd053 - [fastboot] Notify SAI that fastboot is done (#1396) (#1468) (8 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
lguohan
pushed a commit
that referenced
this pull request
Dec 11, 2024
Why I did it e7dc0d2b (HEAD, origin/202405) [202405] Fix compilation error on Buster (#1483) 06d34610 Support SAI_QUEUE_ATTR_TYPE on vs platform simulating MLNX2700 (#1459) 0bd015e3 Do not poll counters in bulk mode during initialization for objects that support bulk per CLI option (#1437) 497bd053 [fastboot] Notify SAI that fastboot is done (#1396) (#1468) PR #21001 raised by automation failed at PR checker. The issue has been fixed and raised a new PR to advance pointer to sonic-sairedis repo.
patrickmacarthur
pushed a commit
to patrickmacarthur/sonic-buildimage
that referenced
this pull request
Dec 11, 2025
…ry start range accept without suffix (sonic-net#1468) … <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it The KDUMP config for memory should accept start value without Suffix(M or G). Default suffix is bytes. Some platforms define the start value without suffix( which is valid and should be accepted) ##### Work item tracking - Microsoft ADO **(number only)**: 33973757 #### How I did it Updated the regex to make the start Memory suffix optional #### How to verify it Added a new test case to ensure that intended config is accepted. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [x] 202405 - [ ] 202411 - [x] 202505 #### Tested branch (Please provide the tested image version) master <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged) Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onie_* variable are generated at runtime in /etc/machine.conf.
We can no longer copy the static machine.conf into sonic image.
- What I did
support new onie machine.conf format
- How I did it
export the onie_* varilable into sonic static machine.conf
- How to verify it
alphanetwork validated.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)