Skip to content

Install python-redis package to docker containers #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 3 commits into from
Apr 20, 2023
Merged

Install python-redis package to docker containers #14632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3567dfb
Ad redis package to docntainers
liuh-80 Apr 13, 2023
c8824d3
Add missing change
liuh-80 Apr 13, 2023
064a533
Revert unecessary code
liuh-80 Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dockers/docker-config-engine-bullseye/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ RUN apt-get install -y \
RUN pip3 install pyangbind==0.8.1
RUN pip3 uninstall -y enum34

# Install python-redis
RUN pip3 install redis==4.5.4
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Apr 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

==4.5.4

@xumia, do we need to specify the version?

Copy link
Copy Markdown
Collaborator

@xumia xumia Apr 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

==4.5.4

@xumia, do we need to specify the version?

If python3-redis installed (redis=3.5.3 currently), then need to specify the version, or use pip3 install --upgrade redis. If the version not specified, then the installation will be skipped, use 3.5.3.

If we need the version 4.5.4 exactly, then "pip3 install redis==4.5.4" is good.
If we want to use the latest version, and at least 4.5.4, use "pip3 install redis>=4.5.4", prefer to auto version upgrade.

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we need exactly 4.5.4, because swsssdk install 4.5.4:

https://github.com/sonic-net/sonic-py-swsssdk/blob/master/setup.py
dependencies = [
'redis==4.5.4;python_version >= "3.0"',
'redis>=3.5.3;python_version < "3.0"',
'redis-dump-load',
]


{% if docker_config_engine_bullseye_debs.strip() %}
# Copy locally-built Debian package dependencies
{{ copy_files("debs/", docker_config_engine_bullseye_debs.split(' '), "/debs/") }}
Expand Down
3 changes: 3 additions & 0 deletions dockers/docker-config-engine-buster/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ RUN apt-get install -y \
RUN pip3 install pyangbind==0.8.1
RUN pip3 uninstall -y enum34

# Install python-redis
RUN pip3 install redis==4.5.4

{% if docker_config_engine_buster_debs.strip() %}
# Copy locally-built Debian package dependencies
{{ copy_files("debs/", docker_config_engine_buster_debs.split(' '), "/debs/") }}
Expand Down
3 changes: 3 additions & 0 deletions dockers/docker-config-engine-stretch/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ RUN apt-get update && \
build-essential \
python-dev

# Install python-redis
RUN pip install redis>=3.5.3

{%- if CONFIGURED_ARCH == "armhf" or CONFIGURED_ARCH == "arm64" %}
RUN apt-get install -y \
libxslt-dev \
Expand Down
3 changes: 3 additions & 0 deletions dockers/docker-config-engine/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ RUN apt-get update
# Dependencies for sonic-cfggen
RUN apt-get install -y build-essential python-dev

# Install python-redis
RUN pip install redis>=3.5.3

{% if docker_config_engine_debs.strip() %}
COPY \
{% for deb in docker_config_engine_debs.split(' ') -%}
Expand Down