Remove default value from SECURE_UPGRADE_DEV_SIGNING_KEY#14582
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Apr 18, 2023
Merged
Remove default value from SECURE_UPGRADE_DEV_SIGNING_KEY#14582qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
This is done because when there is a default value, we mount to this path, and this creates this folder on the host.
Collaborator
|
@davidpil2002 please review this one pls |
davidpil2002
approved these changes
Apr 13, 2023
qiluo-msft
approved these changes
Apr 18, 2023
anamehra
pushed a commit
to anamehra/sonic-buildimage
that referenced
this pull request
Apr 19, 2023
…4582) This is done because when there is a default value, we mount to this path, and this creates this folder on the host. #### Why I did it Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host. #### How I did it Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT #### How to verify it Build SONiC using your own prod script
Collaborator
|
@DavidZagury PR conflicts with 202211 branch |
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 1, 2023
…4582) This is done because when there is a default value, we mount to this path, and this creates this folder on the host. #### Why I did it Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host. #### How I did it Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT #### How to verify it Build SONiC using your own prod script
10 tasks
10 tasks
10 tasks
DavidZagury
added a commit
to DavidZagury/sonic-buildimage
that referenced
this pull request
May 7, 2023
sonic-net#14582) This is done because when there is a default value, we mount to this path, and this creates this folder on the host. Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host. Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT Build SONiC using your own prod script
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 15, 2023
…4582) This is done because when there is a default value, we mount to this path, and this creates this folder on the host. #### Why I did it Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host. #### How I did it Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT #### How to verify it Build SONiC using your own prod script
Collaborator
|
Cherry-pick PR to 202211: #15063 |
StormLiangMS
pushed a commit
that referenced
this pull request
May 15, 2023
…5063) This is done because when there is a default value, we mount to this path, and this creates this folder on the host. #### Why I did it Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host. #### How I did it Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT #### How to verify it Build SONiC using your own prod script Co-authored-by: DavidZagury <32644413+DavidZagury@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done because when there is a default value, we mount to this path, and this creates this folder on the host.
Why I did it
Fix issue that running without overwriting SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT dummy folders are being created on the host.
How I did it
Removed the default assignment to SECURE_UPGRADE_DEV_SIGNING_KEY and SECURE_UPGRADE_DEV_SIGNING_CERT
How to verify it
Build SONiC using your own prod script
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)