Fix backend port channels and routes being displayed

[saiarcot895]

Fixes #14459.

Why I did it

In show interface portchannel and show ip route, backend port channels and routes were being displayed. This is due to changes in #13660. Fix these issues by switching to reading from PORTCHANNEL_MEMBERS table instead.

How I did it

How to verify it

Replaced the multi_asic.py script at /usr/local/lib/python3.9/dist-packages/sonic_py_common/multi_asic.py with the fixed version. Verified that show int portchannel and show ip route no longer showed routes that used the backend port channels.

Current:

admin@xxxxx:~$ show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

C>*1.0.0.0/16 is directly connected, eth1, 1d17h25m
B>*10.106.28.16/31 [200/0] via 10.235.100.134, PortChannel4089, 1d16h16m
  *                        via 10.235.100.4, PortChannel4077, 1d16h16m
  *                        via 10.235.99.134, PortChannel4071, 1d16h16m
  *                        via 10.235.99.4, PortChannel4059, 1d16h16m
  *                        via 10.235.98.134, PortChannel4053, 1d16h16m
  *                        via 10.235.98.4, PortChannel4041, 1d16h16m
  *                        via 10.235.97.134, PortChannel4035, 1d16h16m
  *                        via 10.235.97.4, PortChannel4023, 1d16h16m
  *                        via 10.235.96.134, PortChannel4017, 1d16h16m
  *                        via 10.235.96.4, PortChannel4005, 1d16h16m
...

Fixed:

admin@xxxxxx:~$ show ip route
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

C>*1.0.0.0/16 is directly connected, eth1, 1d17h24m
B> 10.106.28.16/31 [200/0] via 25.103.166.105, (recursive) 1d16h15m
                           via 25.103.166.105, (recursive) 1d16h15m
B> 10.106.28.22/31 [200/0] via 25.103.166.105, (recursive) 1d16h15m
                           via 25.103.166.105, (recursive) 1d16h15m
B> 10.106.28.26/31 [200/0] via 25.103.166.105, (recursive) 1d16h15m
                           via 25.103.166.105, (recursive) 1d16h15m
B> 10.106.28.28/31 [200/0] via 25.103.166.105, (recursive) 1d16h15m
                           via 25.103.166.105, (recursive) 1d16h15m
C>*25.103.166.97/32 is directly connected, Loopback0, 1d17h24m
B> 25.103.166.98/32 [200/0] via 25.103.166.106, (recursive) 1d16h15m
                            via 25.103.166.105, (recursive) 1d16h15m
                            via 25.103.166.105, (recursive) 1d16h15m
                            via 25.103.166.106, (recursive) 1d16h15m
C>*25.103.166.103/32 is directly connected, Loopback4096, 1d17h24m
C>*25.103.166.104/32 is directly connected, Loopback4096, 1d17h24m

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[anamehra]

LGTM. Show CLI works fine with this change.

[anamehra]

This PR also fixes lag_facts for test_lag_2.py test as that uses is_port_channel_internal API fixed here. But I see that the dut_port_map includes internal pcs as well. Earlier only external PCs were included in dut_port_map. That caused the increase in total test cases for test_lag_2 but the internal ones get skipped as lag_facts filter those out with this fix. Is that expected behavior?

[abdosi]

does it fix show interface status. @anamehra / @saiarcot895 can you please confirm

[anamehra]

does it fix show interface status. @anamehra / @saiarcot895 can you please confirm

show interface status and show interface portchannel, shows only external portchannels with this fix.
'-d all' shows all as expected.

[abdosi]

@rlhui can you please help merge this.

[anamehra]

This PR also fixes lag_facts for test_lag_2.py test as that uses is_port_channel_internal API fixed here. But I see that the dut_port_map includes internal pcs as well. Earlier only external PCs were included in dut_port_map. That caused the increase in total test cases for test_lag_2 but the internal ones get skipped as lag_facts filter those out with this fix. Is that expected behavior?

Please ignore this comment. Looks like test metadata was required to be updated on sonic-mgmt ws after patching the fix on the router. After updating the metadata, we do not see internal portchannels in dut_port_map.

[mssonicbld]

Cherry-pick PR to 202205: #14734