Skip to content

[201911] Improve sudo cat command for RO user. (#14428)#14437

Merged
abdosi merged 1 commit intosonic-net:201911from
liuh-80:dev/liuh/fix-cat-201911
Apr 5, 2023
Merged

[201911] Improve sudo cat command for RO user. (#14428)#14437
abdosi merged 1 commit intosonic-net:201911from
liuh-80:dev/liuh/fix-cat-201911

Conversation

@liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Mar 28, 2023

Improve sudo cat command for RO user.
Manually cherry-pick for #14428

Why I did it

RO user can use sudo command show none syslog files.

How I did it

Improve sudo cat command for RO user.

How to verify it

Pass all UT.
Manually check fixed code work correctly.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Improve sudo cat command for RO user.

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Improve sudo cat command for RO user.

RO user can use sudo command show none syslog files.

Improve sudo cat command for RO user.

Pass all UT.
Manually check fixed code work correctly.

Improve sudo cat command for RO user.
@liuh-80 liuh-80 requested a review from qiluo-msft March 28, 2023 00:36
@liuh-80 liuh-80 requested a review from abdosi March 28, 2023 01:16
@liuh-80
Copy link
Contributor Author

liuh-80 commented Mar 28, 2023

This PR need a force merge, currently 201911 branch build break because jessie package deprecated on debian repo:

W: Failed to fetch http://debian-archive.trafficmanager.net/debian/dists/jessie/main/source/Sources 404 Not Found

W: Failed to fetch http://debian-archive.trafficmanager.net/debian/dists/jessie/contrib/source/Sources 404 Not Found

@abdosi
Copy link
Contributor

abdosi commented Mar 30, 2023

@liushilongbuaa / @xumia can you please help look into build failure

@liuh-80
Copy link
Contributor Author

liuh-80 commented Mar 31, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 14437 in repo sonic-net/sonic-buildimage

@xumia
Copy link
Collaborator

xumia commented Mar 31, 2023

@liushilongbuaa / @xumia can you please help look into build failure

Jessie was not supported, and been removed from the mirror, see http://deb.debian.org/debian/dists/;
Suggest to use snapshot, for instance: https://packages.trafficmanager.net/snapshot/debian/20221110T000213Z/dists/jessie/

@liushilongbuaa, could you please change all the references for 201911?

@liuh-80
Copy link
Contributor Author

liuh-80 commented Mar 31, 2023

@liushilongbuaa / @xumia can you please help look into build failure

Jessie was not supported, and been removed from the mirror, see http://deb.debian.org/debian/dists/; Suggest to use snapshot, for instance: https://packages.trafficmanager.net/snapshot/debian/20221110T000213Z/dists/jessie/

@liushilongbuaa, could you please change all the references for 201911?

@xumia @liushilongbuaa ,201811 also break.

@abdosi
Copy link
Contributor

abdosi commented Mar 31, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Apr 3, 2023

@abdosi , could you please help merge this PR? I don't have permission.

@abdosi abdosi merged commit e5c6c2f into sonic-net:201911 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants