[Build] don't install rsync if vcache is disabled#14407
Merged
xumia merged 1 commit intosonic-net:masterfrom Mar 28, 2023
Merged
[Build] don't install rsync if vcache is disabled#14407xumia merged 1 commit intosonic-net:masterfrom
xumia merged 1 commit intosonic-net:masterfrom
Conversation
xumia
approved these changes
Mar 28, 2023
Collaborator
|
LGTM, the build failure may be caused by not running the command "apt-get update". I sent another PR to fix it, #14439. @k-v1, you also cherry-pick the commit in your PR, or rerun the test after the PR merged. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
https://msazure.visualstudio.com/One/_workitems/edit/17813211 Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
jerrychuWis
pushed a commit
to WistronNetworking/sonic-buildimage
that referenced
this pull request
Dec 17, 2025
[Bug/Feature] Bug [Root Causes] in sonic 202211, it will install rsync on all dockers. And it will install rsync on host due to it will be called in sonic-build-hooks. After installation, host will have one more service- rsync.service. The rsync.service need /etc/rsync.conf as critical file. we don't have it. so it always be inactived. [Solution] There have a PR for master which mentioned we don't need to install rsync if vcached is disabled. sonic-net#14407 Since we are not using rsync in host. Turn off as workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
We don't need to install rsync in every docker container if vcache is disabled.
How I did it
Install rsync in pre_run_buildinfo script only if vcache is enabled.
How to verify it