Skip to content

[Edgecore][AS4630-54TE] Enhance sonic_platform feature#14364

Closed
roger530-ho wants to merge 10 commits intosonic-net:masterfrom
roger530-ho:as4630-54te_20230321_pytest
Closed

[Edgecore][AS4630-54TE] Enhance sonic_platform feature#14364
roger530-ho wants to merge 10 commits intosonic-net:masterfrom
roger530-ho:as4630-54te_20230321_pytest

Conversation

@roger530-ho
Copy link
Contributor

Why I did it

To pass pytest.

How I did it

Add needed code to sonic_platform.

How to verify it

  1. sonic-cli cmd:
    show platform {fan, temperature, firmware status, syseeprom, psustatus}
  2. sfputil cmd:
    show {presence, eeprom, lpmode}
  3. Verify function by sonic-mgmt tools:
    Test file path: /tests/platform_tests/api/
    Test items: test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@roger530-ho roger530-ho requested a review from lguohan as a code owner March 21, 2023 03:24
@mssonicbld
Copy link
Collaborator

@StormLiangMS,@liushilongbuaa PR: #14364 is conflict with MS internal repo
Please complete the following PR by pushing fix commit to sonicbld/conflict_prefix/14364-fix
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9229909
Then comment "/azpw ms_conflict" to rerun PR checker.

@liushilongbuaa
Copy link
Contributor

@ec-michael-shih , this PR is too old. please rebase latest master.

@mssonicbld
Copy link
Collaborator

@StormLiangMS,@liushilongbuaa PR: #14364 is conflict with MS internal repo
Please complete the following PR by pushing fix commit to sonicbld/conflict_prefix/14364-fix
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9229909
Then comment "/azpw ms_conflict" to rerun PR checker.

@roger530-ho
Copy link
Contributor Author

/azpw ms_conflict

@roger530-ho
Copy link
Contributor Author

Migrated to PR #23934 for a combined review.

@roger530-ho roger530-ho closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants