Skip to content

[action] [PR:14178] [lldpmgrd] Don't log error message for outdated event#14334

Merged
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/14178
Mar 20, 2023
Merged

[action] [PR:14178] [lldpmgrd] Don't log error message for outdated event#14334
mssonicbld merged 1 commit intosonic-net:202211from
mssonicbld:cherry/202211/14178

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

No description provided.

- Why I did it
Fixes sonic-net#14236

When a redis event quickly gets outdated during port breakout, error logs like this are seen

Mar  8 01:43:26.011724 r-leopard-56 INFO ConfigMgmt: Write in DB: {'PORT': {'Ethernet64': {'admin_status': 'down'}, 'Ethernet68': {'admin_status': 'down'}}}
Mar  8 01:43:26.012565 r-leopard-56 INFO ConfigMgmt: Writing in Config DB
Mar  8 01:43:26.013468 r-leopard-56 INFO ConfigMgmt: Write in DB: {'PORT': {'Ethernet64': None, 'Ethernet68': None}, 'INTERFACE': None}
Mar  8 01:43:26.018095 r-leopard-56 NOTICE swss#portmgrd: :- doTask: Configure Ethernet64 admin status to down
Mar  8 01:43:26.018309 r-leopard-56 NOTICE swss#portmgrd: :- doTask: Delete Port: Ethernet64
Mar  8 01:43:26.018641 r-leopard-56 NOTICE lldp#lldpmgrd[32]: :- pops: Miss table key PORT_TABLE:Ethernet64, possibly outdated
Mar  8 01:43:26.018654 r-leopard-56 ERR lldp#lldpmgrd[32]: unknown operation ''

- How I did it
Only log the error when the op is not empty and not one of ("SET" & "DEL" )

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #14178

@mssonicbld mssonicbld merged commit 4dc61fc into sonic-net:202211 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants