[pfcwd]: add flag to enable pfc wd on start#1429
Conversation
Signed-off-by: Sihui Han <[email protected]>
Makefile
Outdated
| # * ENABLE_DHCP_GRAPH_SERVICE: Enables get-graph service to fetch minigraph files | ||
| # through http. | ||
| # * SHUTDOWN_BGP_ON_START: Sets admin-down state for all bgp peerings after restart. | ||
| # * ENABLE_PFC_WD_ON_START: Enable PFCWD on server-facing ports when starts. |
There was a problem hiding this comment.
use PFCWD consistently throughout the CR?
There was a problem hiding this comment.
Enable PFC WatchDog (PFCWD) on server-facing ports by default for TOR switch.
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_bgp_status\": \"down\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | ||
| {% endif %} | ||
| {% if enable_pfc_wd_on_start == "y" %} | ||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_pfc_wd_status\": \"enable\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" |
There was a problem hiding this comment.
which agent is reading this DEVICE_METADATA default_pfc_wd_status, where is that code?
There was a problem hiding this comment.
There was a problem hiding this comment.
if the PR is related/depended to other PR, can you mark this information in the PR comments?
Makefile
Outdated
| # * ENABLE_DHCP_GRAPH_SERVICE: Enables get-graph service to fetch minigraph files | ||
| # through http. | ||
| # * SHUTDOWN_BGP_ON_START: Sets admin-down state for all bgp peerings after restart. | ||
| # * ENABLE_PFC_WD_ON_START: Enable PFCWD on server-facing ports when starts. |
There was a problem hiding this comment.
Suggest change to ENABLE_PFC_WD_ON_START: Enable PFC Watchdog on server-facing ports when SONiC starts. for clarity.
rules/config
Outdated
| # bgp service starts. | ||
| # SHUTDOWN_BGP_ON_START = y | ||
|
|
||
| # ENABLE_PFC_WD_ON_START - if set to y PFC WD will be enabled all server-facing ports when |
There was a problem hiding this comment.
Suggest changing WD to Watchdog for clarity.
Signed-off-by: Sihui Han <[email protected]>
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_bgp_status\": \"down\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" | ||
| {% endif %} | ||
| {% if enable_pfcwd_on_start == "y" %} | ||
| sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_pfc_wd_status\": \"enable\" } } }' >> $FILESYSTEM_ROOT/etc/sonic/init_cfg.json" |
There was a problem hiding this comment.
to be consistent, this should also be default_pfcwd_status
Signed-off-by: Sihui Han <[email protected]>
Makefile
Outdated
| ENABLE_DHCP_GRAPH_SERVICE=$(ENABLE_DHCP_GRAPH_SERVICE) \ | ||
| SHUTDOWN_BGP_ON_START=$(SHUTDOWN_BGP_ON_START) \ | ||
| ENABLE_PFC_WD_ON_START=$(ENABLE_PFC_WD_ON_START) \ | ||
| ENABLE_PFCWD_ON_START=$(ENABLE_PFCWD_ON_START) \ |
There was a problem hiding this comment.
This will always rewrite value in config file
There was a problem hiding this comment.
Warn user while deleting VLAN if it has IP addresses. Signed-off-by: d-dashkov <[email protected]>
4 participants
Signed-off-by: Sihui Han [email protected]
- What I did
Add flag to enable pfc wd on start
- How I did it
Add the option to enable pfc wd on start
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)