Syncd graceful shutdown should not be ignored#14129
Closed
Junchao-Mellanox wants to merge 2 commits intosonic-net:masterfrom
Closed
Syncd graceful shutdown should not be ignored#14129Junchao-Mellanox wants to merge 2 commits intosonic-net:masterfrom
Junchao-Mellanox wants to merge 2 commits intosonic-net:masterfrom
Conversation
nazariig
previously approved these changes
Mar 7, 2023
liat-grozovik
previously approved these changes
Mar 7, 2023
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
sairedis PR has merged, pending submodule update PR #14235 |
Collaborator
Author
|
Hi @saiarcot895, @qiluo-msft , could you please help review this? |
dgsudharsan
approved these changes
Mar 21, 2023
Collaborator
Author
|
Hi @saiarcot895, @qiluo-msft , kindly reminder. |
Collaborator
|
@saiarcot895 @qiluo-msft would you please help to review? |
qiluo-msft
reviewed
Apr 14, 2023
| debug "Stopped pmon service" | ||
| fi | ||
|
|
||
| if [[ x$sonic_asic_platform != x"mellanox" ]] || [[ x$TYPE != x"cold" ]]; then |
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Hi @qiluo-msft , we intend to remove the whole if block because:
- if platform is not mellanox, it will trigger graceful shutdown flow no matter what type it is. It means that removing the condition won't affect any other vendor.
- if platform is mellanox, it will trigger graceful shutdown if type is not cold (old logic). This is exactly what we try to fix. We move the
type != coldcheck to Syncd.cpp, see PR Ignore removing switch for mellanox platform due to known limitation sonic-sairedis#1216 .
Collaborator
There was a problem hiding this comment.
@qiluo-msft would you please check the feedback from Junchao?
qiluo-msft
approved these changes
Apr 22, 2023
Collaborator
|
@Junchao-Mellanox IMO this fix is not relevant any more and the sairedis changes were reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-sairedis#1216
Why I did this?
Due to a limitation in mellanox platform, sonic ignores syncs graceful shutdown in syncd.sh previously. However, ignoring graceful shutdown in syncd.sh also ignores closing other resources such as removing all counters.
This PR changes syncd shutdown flow for mellanox platform to make sure it execute graceful shutdown flow. There is another PR for sonic-sairedis to make sure mellanox platform does not call remove_switch for cold shutdown.
How I test this?
Running config reload on many platforms and check result.