Skip to content

[build] Fix issues caused by docker.com gpg key update.#14063

Merged
xumia merged 1 commit intosonic-net:201911from
liushilongbuaa:201911-fix-apt
Mar 6, 2023
Merged

[build] Fix issues caused by docker.com gpg key update.#14063
xumia merged 1 commit intosonic-net:201911from
liushilongbuaa:201911-fix-apt

Conversation

@liushilongbuaa
Copy link
Copy Markdown
Contributor

@liushilongbuaa liushilongbuaa commented Mar 3, 2023

Why I did it

docker.com's gpg key start to work from 2023-02-23. While debian.org's gpg key expired in 2022-11.
We used a walkaround for security checking for debian gpg keys. Now we need to exclude docker.com's gpg key.

How I did it

Update docker.com's gpg key without faketime.
Update others' gpg key with faketime '2022-11'

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Mar 3, 2023

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi requested review from saiarcot895 and xumia March 3, 2023 22:32
@abdosi
Copy link
Copy Markdown
Contributor

abdosi commented Mar 3, 2023

@liushilongbuaa is this PR good for review/merge ?

@liushilongbuaa liushilongbuaa marked this pull request as ready for review March 6, 2023 01:59
@xumia
Copy link
Copy Markdown
Collaborator

xumia commented Mar 6, 2023

@liushilongbuaa , please update the description for the PR, thanks.

@xumia xumia added the Build label Mar 6, 2023
@xumia xumia merged commit ef0c6f3 into sonic-net:201911 Mar 6, 2023
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Apr 5, 2023
)

Why I did it
docker.com's gpg key start to work from 2023-02-23. While debian.org's gpg key expired in 2022-11.
We used a walkaround for security checking for debian gpg keys. Now we need to exclude docker.com's gpg key.

How I did it
Update docker.com's gpg key without faketime.
Update others' gpg key with faketime '2022-11'

How to verify it
yxieca pushed a commit that referenced this pull request Apr 7, 2023
* [Build][201811] Fix the jessie mirror removed issue

* Fix build break for jessie apt key expiration. (#13328)

The GPG key used for Jessie's official repos has since expired, which means building 201911 images no longer works.

Fake the time to be before the expiry date.

* [build] Fix issues caused by docker.com gpg key update. (#14063)

Why I did it
docker.com's gpg key start to work from 2023-02-23. While debian.org's gpg key expired in 2022-11.
We used a walkaround for security checking for debian gpg keys. Now we need to exclude docker.com's gpg key.

How I did it
Update docker.com's gpg key without faketime.
Update others' gpg key with faketime '2022-11'

How to verify it

* Fix build break for jessie apt key expiration

---------

Co-authored-by: Saikrishna Arcot <[email protected]>
Co-authored-by: Liu Shilong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants