Skip to content

Fix issue: enhancing PDDF common eeprom APIs to use caching (#13835) #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 1 commit into from
Mar 15, 2023
Merged

Fix issue: enhancing PDDF common eeprom APIs to use caching (#13835) #13848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddf_eeprom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@

try:
from sonic_eeprom import eeprom_tlvinfo
import os
except ImportError as e:
raise ImportError(str(e) + "- required module not found")

CACHE_ROOT = '/var/cache/sonic/decode-syseeprom'
CACHE_FILE = 'syseeprom_cache'

class PddfEeprom(eeprom_tlvinfo.TlvInfoDecoder):
_TLV_INFO_MAX_LEN = 256
Expand All @@ -29,6 +32,20 @@ def __init__(self, pddf_data=None, pddf_plugin_data=None):

super(PddfEeprom, self).__init__(self.eeprom_path, 0, '', True)
self.eeprom_tlv_dict = dict()

# Create the cache directory if not created
if not os.path.exists(CACHE_ROOT):
try:
os.makedirs(CACHE_ROOT)
except Exception as e:
print("Error in creating Eeprom cache directory - {}".format(str(e)))

# Assign cache_name in eeprom_base.py
try:
self.set_cache_name(os.path.join(CACHE_ROOT, CACHE_FILE))
except:
pass

try:
self.eeprom_data = self.read_eeprom()
except:
Expand All @@ -37,6 +54,11 @@ def __init__(self, pddf_data=None, pddf_plugin_data=None):
else:
eeprom = self.eeprom_data

try:
self.update_cache(eeprom)
except:
pass

if not self.is_valid_tlvinfo_header(eeprom):
return

Expand Down