-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add QoS profiles for Arista SKUs #13829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers.json.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| {%- set default_topo = 't2' %} | ||
| {%- include 'buffers_config.j2' %} |
37 changes: 37 additions & 0 deletions
37
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| {%- set default_cable = '300m' %} | ||
|
|
||
| {%- macro generate_port_lists(PORT_ALL) %} | ||
| {# Generate list of ports #} | ||
| {%- for port_idx in range(0,144,8) %} | ||
| {%- if PORT_ALL.append("Ethernet%d" % (port_idx)) %}{%- endif %} | ||
| {%- endfor %} | ||
| {%- endmacro %} | ||
|
|
||
| {%- macro generate_buffer_pool_and_profiles() %} | ||
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| "size": "6441610000", | ||
| "type": "both", | ||
| "mode": "dynamic", | ||
| "xoff": "11354112" | ||
| } | ||
| }, | ||
| "BUFFER_PROFILE": { | ||
| "ingress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"1280", | ||
| "xon_offset": "2560", | ||
| "dynamic_th":"0" | ||
| }, | ||
| "egress_lossless_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"33030144" | ||
| }, | ||
| "egress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "dynamic_th":"-1" | ||
| } | ||
| }, | ||
| {%- endmacro %} | ||
17 changes: 17 additions & 0 deletions
17
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/pg_profile_lookup.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # PG lossless profiles. | ||
| # speed cable size xon xoff threshold xon_offset | ||
| 40000 300m 1280 2560 69632 0 1280 | ||
| 100000 300m 1280 2560 110592 0 1280 | ||
| 400000 300m 1280 2560 315392 0 1280 | ||
| 40000 1000m 1280 2560 114688 0 1280 | ||
| 100000 1000m 1280 2560 225280 0 1280 | ||
| 400000 1000m 1280 2560 778240 0 1280 | ||
| 40000 2000m 1280 2560 184320 0 1280 | ||
| 100000 2000m 1280 2560 393216 0 1280 | ||
| 400000 2000m 1280 2560 1445888 0 1280 | ||
| 40000 80000m 1280 2560 5369856 0 1280 | ||
| 100000 80000m 1280 2560 13357056 0 1280 | ||
| 400000 80000m 1280 2560 53305344 0 1280 | ||
| 40000 120000m 1280 2560 8028160 0 1280 | ||
| 100000 120000m 1280 2560 20004864 0 1280 | ||
| 400000 120000m 1280 2560 79900672 0 1280 |
1 change: 1 addition & 0 deletions
1
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/qos.json.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {%- include 'qos_config.j2' %} |
2 changes: 2 additions & 0 deletions
2
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/1/buffers.json.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| {%- set default_topo = 't2' %} | ||
| {%- include 'buffers_config.j2' %} |
37 changes: 37 additions & 0 deletions
37
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/1/buffers_defaults_t2.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| {%- set default_cable = '300m' %} | ||
|
|
||
| {%- macro generate_port_lists(PORT_ALL) %} | ||
| {# Generate list of ports #} | ||
| {%- for port_idx in range(144,288,8) %} | ||
| {%- if PORT_ALL.append("Ethernet%d" % (port_idx)) %}{%- endif %} | ||
| {%- endfor %} | ||
| {%- endmacro %} | ||
|
|
||
| {%- macro generate_buffer_pool_and_profiles() %} | ||
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| "size": "6441610000", | ||
| "type": "both", | ||
| "mode": "dynamic", | ||
| "xoff": "11354112" | ||
| } | ||
| }, | ||
| "BUFFER_PROFILE": { | ||
| "ingress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"1280", | ||
| "xon_offset": "2560", | ||
| "dynamic_th":"0" | ||
| }, | ||
| "egress_lossless_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"33030144" | ||
| }, | ||
| "egress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "dynamic_th":"-1" | ||
| } | ||
| }, | ||
| {%- endmacro %} |
17 changes: 17 additions & 0 deletions
17
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/1/pg_profile_lookup.ini
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # PG lossless profiles. | ||
| # speed cable size xon xoff threshold xon_offset | ||
| 40000 300m 1280 2560 69632 0 1280 | ||
| 100000 300m 1280 2560 110592 0 1280 | ||
| 400000 300m 1280 2560 315392 0 1280 | ||
| 40000 1000m 1280 2560 114688 0 1280 | ||
| 100000 1000m 1280 2560 225280 0 1280 | ||
| 400000 1000m 1280 2560 778240 0 1280 | ||
| 40000 2000m 1280 2560 184320 0 1280 | ||
| 100000 2000m 1280 2560 393216 0 1280 | ||
| 400000 2000m 1280 2560 1445888 0 1280 | ||
| 40000 80000m 1280 2560 5369856 0 1280 | ||
| 100000 80000m 1280 2560 13357056 0 1280 | ||
| 400000 80000m 1280 2560 53305344 0 1280 | ||
| 40000 120000m 1280 2560 8028160 0 1280 | ||
| 100000 120000m 1280 2560 20004864 0 1280 | ||
| 400000 120000m 1280 2560 79900672 0 1280 |
1 change: 1 addition & 0 deletions
1
device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/1/qos.json.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {%- include 'qos_config.j2' %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ysmanman Rest of the setting look ok. Can you please share calculation details for XOFF ? Also, are these profiles going to cover all Wolverine SKUs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kenneth-arista , @ysmanman - reminder of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion, these settings are to unblock testing and not the final one. I will raise another PR to update these settings based on cable length we are planning to use.