[dhcp-relay] Add dhcp_relay show cli#13614
Conversation
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yaqiangz
force-pushed
the
master_dhcp_relay_show
branch
from
7982b91 to
4c01273
Compare
|
@yxieca Could you please help to do final sign-off to this PR and merge it? Thanks :) |
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
Why changing IPv6 helper table name?
Hi @yxieca, this is not table name in db, it's just test case name. Table name is in line 6, line 22 of mock_config.py ("DHCP_RELAY") which is not changed. Change in line 3 is shown in test results which is in bold below: test_show_dhcp_relay.py::test_show_dhcp_relay_0_ipv6_with_header <- ../../../../usr/local/lib/python3.9/dist-packages/pyfakefs/fake_filesystem_unittest.py PASSED [ 92%] I think such a change is more reasonable and understandable. |
Why I did it Currently the show and clear cli of dhcp_relayis may cause confusion. How I did it Add doc for it: [doc] Add docs for dhcp_relay show/clear cli sonic-utilities#2649 Add dhcp_relay config cli and test cases. show dhcp_relay ipv4 helper show dhcp_relay ipv6 destination show dhcp_relay ipv6 counters sonic-clear dhcp_relay ipv6 counters How to verify it Unit test all passed
|
Cherry-pick PR to 202205: #14107 |
Why I did it Currently the show and clear cli of dhcp_relayis may cause confusion. How I did it Add doc for it: [doc] Add docs for dhcp_relay show/clear cli sonic-utilities#2649 Add dhcp_relay config cli and test cases. show dhcp_relay ipv4 helper show dhcp_relay ipv6 destination show dhcp_relay ipv6 counters sonic-clear dhcp_relay ipv6 counters How to verify it Unit test all passed
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
What I did Add support for dhcp_relay show cli, consistent with sonic-net/sonic-buildimage#13614 How I did it Add support for dhcp_relay show cli How to verify it 1. UT 2. build wheel and install in device Signed-off-by: Yaqiang Zhu <[email protected]>
|
@yaqiangz Any reason we use “helper” for ipv4 and “destination” for ipv6 ? |
Helpers are DHCPv4 only concept, DHCPv6 it use relay destination. |
Why I did it Currently the show and clear cli of dhcp_relayis may cause confusion. How I did it Add doc for it: [doc] Add docs for dhcp_relay show/clear cli sonic-utilities#2649 Add dhcp_relay config cli and test cases. show dhcp_relay ipv4 helper show dhcp_relay ipv6 destination show dhcp_relay ipv6 counters sonic-clear dhcp_relay ipv6 counters How to verify it Unit test all passed
Thanks, i understand we use this terminology is SONiC. Could you point me towards an RFC or something where this terminology is used/defined. I tried to search but couldn't find it. |
helper address is first known as ip helper address (not only for dhcp), it's v4 only concept. Not sure which RFC mentioned it first, it may first mentioned in cisco ios-cli https://www.ciscopress.com/articles/article.asp?p=330807&seqNum=9 |
Why I did it Currently the show and clear cli of dhcp_relayis may cause confusion. How I did it Add doc for it: [doc] Add docs for dhcp_relay show/clear cli sonic-utilities#2649 Add dhcp_relay config cli and test cases. show dhcp_relay ipv4 helper show dhcp_relay ipv6 destination show dhcp_relay ipv6 counters sonic-clear dhcp_relay ipv6 counters How to verify it Unit test all passed
|
Cherry-pick PR to 202211: #14342 |
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
8 participants
Why I did it
Currently the show and clear cli of dhcp_relayis may cause confusion.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)