[Dash] Fix a typo in yang model#13325
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jan 11, 2023
Merged
Conversation
qiluo-msft
approved these changes
Jan 10, 2023
ganglyu
reviewed
Jan 11, 2023
|
|
||
| leaf vnet { | ||
| when "((current()/../action_type = 'vnet') or (current()/../action_type = 'vnet-direct'))"; | ||
| when "((current()/../action_type = 'vnet') or (current()/../action_type = 'vnet_direct'))"; |
Contributor
There was a problem hiding this comment.
Would you please add unit test for this action_type?
Contributor
Author
There was a problem hiding this comment.
sure, will add. i would like to unblock the issue first as this is a typo fix.
ganglyu
reviewed
Jan 11, 2023
| when "((current()/../action_type = 'vnet') or (current()/../action_type = 'vnet-direct'))"; | ||
| description "Overlay IP to use for mapping lookup, if routing_type is vnet-direct"; | ||
| when "((current()/../action_type = 'vnet') or (current()/../action_type = 'vnet_direct'))"; | ||
| description "Overlay IP to use for mapping lookup, if routing_type is vnet_direct"; |
Contributor
There was a problem hiding this comment.
action_type or routing_type?
Contributor
Author
There was a problem hiding this comment.
action_type points to a routing_type, so it is used interchangeably.
ganglyu
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix a typo in yang
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)