[hash] Add Generic Hash YANG model

[nazariig]

Signed-off-by: Nazarii Hnydyn [email protected]

HLD: sonic-net/SONiC#1101

Why I did it

• Added YANG model as part of Generic Hash feature development

How I did it

• Added YANG model and UTs

How to verify it

1. make configure PLATFORM=mellanox
2. make target/sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211

Description for the changelog

• N/A

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

• N/A

Link to config_db schema for YANG module changes

• N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

[liat-grozovik]

@nazariig please provide more details on the change in the PR description
@qiluo-msft , @zhangyanzhao could you please cover it in the yang subgroup for review?

[liat-grozovik]

@qiluo-msft @dgsudharsan can u please review ?

[ganglyu]

Would you please update doc/Configuration.md?

[nazariig]

Would you please update doc/Configuration.md?

@ganglyu can it go as a separate PR?

[liat-grozovik]

I prefer it will go in the same pr if possible Code changes along with the documentation Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Nazarii Hnydyn ***@***.***> Sent: Monday, January 30, 2023 5:48:29 PM To: sonic-net/sonic-buildimage ***@***.***> Cc: Liat Grozovik ***@***.***>; Review requested ***@***.***> Subject: Re: [sonic-net/sonic-buildimage] [hash]: Add GH YANG model (PR #13253) Would you please update doc/Configuration.md? @ganglyu<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fganglyu&data=05%7C01%7Cliatg%40nvidia.com%7Cb5a55af2c7664a99951408db02d96f75%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638106905124946129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2InQk3yjrkMLkIAaR2KCo5z372nLJUskoaISNjwoNlY%3D&reserved=0> can it go as a separate PR? — Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsonic-net%2Fsonic-buildimage%2Fpull%2F13253%23issuecomment-1408861097&data=05%7C01%7Cliatg%40nvidia.com%7Cb5a55af2c7664a99951408db02d96f75%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638106905124946129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J6GsobyIY2x8AqpkWMzpI2vIrc%2BjiYAV1RF4gquQQd8%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKTABA3PCQZKTPHYI6SYME3WU7PE3ANCNFSM6AAAAAATQYZZUE&data=05%7C01%7Cliatg%40nvidia.com%7Cb5a55af2c7664a99951408db02d96f75%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638106905124946129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pUoXYPt24VYdkWxrDJiXk%2BTCMnxfqGWVBF1YWSwgT4w%3D&reserved=0>. You are receiving this because your review was requested.Message ID: ***@***.***>

[nazariig]

Would you please update doc/Configuration.md?

@ganglyu done

[nazariig]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

[nazariig]

/azpw run Azure.sonic-buildimage

[mssonicbld]

/AzurePipelines run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nazariig]

PR check failed due to:

test_pretest.py::test_disable_rsyslog_rate_limit[vlab-08] 
-------------------------------- live log call ---------------------------------
17:40:22 __init__.pytest_runtest_call             L0040 ERROR  | Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/_pytest/python.py", line 1464, in runtest
    self.ihook.pytest_pyfunc_call(pyfuncitem=self)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 286, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 93, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 87, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
    _reraise(*ex)  # noqa
  File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/usr/local/lib/python2.7/dist-packages/_pytest/python.py", line 174, in pytest_pyfunc_call
    testfunction(**testargs)
  File "/var/src/sonic-mgmt/tests/test_pretest.py", line 172, in test_disable_rsyslog_rate_limit
    duthost.modify_syslog_rate_limit(feature_name, rl_option='disable')
  File "/var/src/sonic-mgmt/tests/common/devices/multi_asic.py", line 476, in modify_syslog_rate_limit
    self.sonichost.shell_cmds(cmds=cmds)
  File "/var/src/sonic-mgmt/tests/common/devices/base.py", line 90, in _run
    raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
RunAnsibleModuleFail: run module shell_cmds failed, Ansible Results =>
{"changed": false, "cmds": ["docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", "docker exec -i teamd0 supervisorctl restart rsyslogd"], "delta": "0:00:02.672187", "end": "2023-02-02 17:40:22.063874", "failed": true, "msg": "At least running one of the commands failed", "results": [{"cmd": "docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", "rc": 0, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}, {"cmd": "docker exec -i teamd0 supervisorctl restart rsyslogd", "rc": 7, "stderr": "", "stderr_lines": [], "stdout": "rsyslogd: ERROR (not running)\nrsyslogd: ERROR (spawn error)\n", "stdout_lines": ["rsyslogd: ERROR (not running)", "rsyslogd: ERROR (spawn error)"]}], "start": "2023-02-02 17:40:19.391687"}

Thursday 02 February 2023  17:40:22 +0000 (0:00:03.319)       0:03:30.043 ***** 


=================================== FAILURES ===================================
___________________ test_disable_rsyslog_rate_limit[vlab-08] ___________________

duthosts = [<MultiAsicSonicHost vlab-08>], enum_dut_hostname = 'vlab-08'

    def test_disable_rsyslog_rate_limit(duthosts, enum_dut_hostname):
        duthost = duthosts[enum_dut_hostname]
        features_dict, succeed = duthost.get_feature_status()
        if not succeed:
            # Something unexpected happened.
            # We don't want to fail here because it's an util
            logging.warn("Failed to retrieve feature status")
            return
        config_facts = duthost.config_facts(host=duthost.hostname, source="running")
        try:
            is_dhcp_server_enable = config_facts["ansible_facts"]["DEVICE_METADATA"]["localhost"]["dhcp_server"]
        except KeyError:
            is_dhcp_server_enable = None
        for feature_name, state in features_dict.items():
            if 'enabled' not in state:
                continue
            # Skip dhcp_relay check if dhcp_server is enabled
            if is_dhcp_server_enable is not None and "enabled" in is_dhcp_server_enable and feature_name == "dhcp_relay":
                continue
>           duthost.modify_syslog_rate_limit(feature_name, rl_option='disable')

config_facts = {u'invocation': {u'module_args': {u'source': u'running', u'host': u'vlab-08', ...rnet1/5': u'', u'Ethernet1/6': u'', u'Ethernet1/7': u'', u'Ethernet1/8': u''}}}
duthost    = <MultiAsicSonicHost vlab-08>
duthosts   = [<MultiAsicSonicHost vlab-08>]
enum_dut_hostname = 'vlab-08'
feature_name = 'teamd'
features_dict = {'bgp': 'enabled', 'database': 'always_enabled', 'dhcp_relay': 'disabled', 'eventd': 'enabled', ...}
is_dhcp_server_enable = None
state      = 'enabled'
succeed    = True

test_pretest.py:172: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
common/devices/multi_asic.py:476: in modify_syslog_rate_limit
    self.sonichost.shell_cmds(cmds=cmds)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <SonicHost vlab-08>, module_args = ()
complex_args = {'cmds': ["docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", 'docker exec -i teamd0 supervisorctl restart rsyslogd']}
previous_frame = <frame object at 0x55e361df5c10>
filename = '/var/src/sonic-mgmt/tests/common/devices/multi_asic.py'
line_number = 476, function_name = 'modify_syslog_rate_limit'
lines = ['            self.sonichost.shell_cmds(cmds=cmds)\n'], index = 0
verbose = True, module_ignore_errors = False, module_async = False

    def _run(self, *module_args, **complex_args):
    
        previous_frame = inspect.currentframe().f_back
        filename, line_number, function_name, lines, index = inspect.getframeinfo(previous_frame)
    
        verbose = complex_args.pop('verbose', True)
    
        if verbose:
            logging.debug("{}::{}#{}: [{}] AnsibleModule::{}, args={}, kwargs={}"
                          .format(filename, function_name, line_number, self.hostname,
                                  self.module_name, json.dumps(module_args), json.dumps(complex_args)))
        else:
            logging.debug("{}::{}#{}: [{}] AnsibleModule::{} executing..."
                          .format(filename, function_name, line_number, self.hostname, self.module_name))
    
        module_ignore_errors = complex_args.pop('module_ignore_errors', False)
        module_async = complex_args.pop('module_async', False)
    
        if module_async:
            def run_module(module_args, complex_args):
                return self.module(*module_args, **complex_args)[self.hostname]
            pool = ThreadPool()
            result = pool.apply_async(run_module, (module_args, complex_args))
            return pool, result
    
        res = self.module(*module_args, **complex_args)[self.hostname]
    
        if verbose:
            logging.debug("{}::{}#{}: [{}] AnsibleModule::{} Result => {}"
                          .format(filename, function_name, line_number,
                                  self.hostname, self.module_name, json.dumps(res)))
        else:
            logging.debug("{}::{}#{}: [{}] AnsibleModule::{} done, is_failed={}, rc={}"
                          .format(filename, function_name, line_number, self.hostname,
                                  self.module_name, res.is_failed, res.get('rc', None)))
    
        if (res.is_failed or 'exception' in res) and not module_ignore_errors:
>           raise RunAnsibleModuleFail("run module {} failed".format(self.module_name), res)
E           RunAnsibleModuleFail: run module shell_cmds failed, Ansible Results =>
E           {"changed": false, "cmds": ["docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", "docker exec -i teamd0 supervisorctl restart rsyslogd"], "delta": "0:00:02.672187", "end": "2023-02-02 17:40:22.063874", "failed": true, "msg": "At least running one of the commands failed", "results": [{"cmd": "docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", "rc": 0, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}, {"cmd": "docker exec -i teamd0 supervisorctl restart rsyslogd", "rc": 7, "stderr": "", "stderr_lines": [], "stdout": "rsyslogd: ERROR (not running)\nrsyslogd: ERROR (spawn error)\n", "stdout_lines": ["rsyslogd: ERROR (not running)", "rsyslogd: ERROR (spawn error)"]}], "start": "2023-02-02 17:40:19.391687"}

complex_args = {'cmds': ["docker exec -i teamd0 sed -i 's/^\\$SystemLogRateLimit/#\\$SystemLogRateLimit/g' /etc/rsyslog.conf", 'docker exec -i teamd0 supervisorctl restart rsyslogd']}
filename   = '/var/src/sonic-mgmt/tests/common/devices/multi_asic.py'
function_name = 'modify_syslog_rate_limit'
index      = 0
line_number = 476
lines      = ['            self.sonichost.shell_cmds(cmds=cmds)\n']
module_args = ()
module_async = False
module_ignore_errors = False
previous_frame = <frame object at 0x55e361df5c10>
res        = {u'end': u'2023-02-02 17:40:22.063874', '_ansible_no_log': False, 'failed': Tr...l restart rsyslogd']}}, u'msg': u'At least running one of the commands failed'}
self       = <SonicHost vlab-08>
verbose    = True

common/devices/base.py:90: RunAnsibleModuleFail
--- generated xml file: /var/src/sonic-mgmt/tests/logs/test_pretest|||0.xml ----
=========================== short test summary info ============================
FAILED test_pretest.py::test_disable_rsyslog_rate_limit[vlab-08] - RunAnsible...
===================== 1 failed, 3 passed in 221.41 seconds =====================

[nazariig]

/azpw run Azure.sonic-buildimage

[mssonicbld]

/AzurePipelines run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nazariig]

/azpw run Azure.sonic-buildimage

[mssonicbld]

/AzurePipelines run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nazariig]

/azpw run Azure.sonic-buildimage

[mssonicbld]

/AzurePipelines run Azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).