Skip to content

[Cherry-pick]Remove PYTHON_THRIFT_0_14_1 (#12169)#12782

Closed
richardyu-ms wants to merge 1 commit intosonic-net:masterfrom
richardyu-ms:fix_saiserverv2
Closed

[Cherry-pick]Remove PYTHON_THRIFT_0_14_1 (#12169)#12782
richardyu-ms wants to merge 1 commit intosonic-net:masterfrom
richardyu-ms:fix_saiserverv2

Conversation

@richardyu-ms
Copy link
Copy Markdown
Contributor

@richardyu-ms richardyu-ms commented Nov 21, 2022

Why I did it

THRIFT_VERSION = 0.11.0
THRIFT_VERSION_FULL = $(THRIFT_VERSION)-4

MAIN_TARGET = libthrift-$(THRIFT_VERSION)_$(THRIFT_VERSION_FULL)_$(CONFIGURED_ARCH).deb
DERIVED_TARGETS = libthrift-dev_$(THRIFT_VERSION_FULL)_$(CONFIGURED_ARCH).deb \
		  python-thrift_$(THRIFT_VERSION_FULL)_$(CONFIGURED_ARCH).deb \
		  thrift-compiler_$(THRIFT_VERSION_FULL)_$(CONFIGURED_ARCH).deb

For thrift 0.14
https://github.com/sonic-net/sonic-buildimage/blob/master/src/thrift_0_14_1/Makefile#L5

THRIFT_VERSION = 0.14.1

MAIN_TARGET = libthrift0_$(THRIFT_VERSION)_$(CONFIGURED_ARCH).deb
DERIVED_TARGETS = libthrift-dev_$(THRIFT_VERSION)_$(CONFIGURED_ARCH).deb \
		  python3-thrift_$(THRIFT_VERSION)_$(CONFIGURED_ARCH).deb \
		  thrift-compiler_$(THRIFT_VERSION)_$(CONFIGURED_ARCH).deb

when build this target, there will be an error

tar: target/debs/buster/python-thrift_0.14.1_amd64.deb: Cannot stat: No such file or directory

Cause no build target depends on PYTHON_THRIFT_0_14_1, remove this target from build

How I did it

Remove PYTHON_THRIFT_0_14_1 from rules/thrift_0_14_1.mk.

How to verify it

Run pipeline internally and docker-saiserverv2 is built successfully.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: zitingguo-ms <[email protected]>

Signed-off-by: zitingguo-ms <[email protected]>
@richardyu-ms
Copy link
Copy Markdown
Contributor Author

close this one, as there is a fix from the root cause

@richardyu-ms richardyu-ms reopened this Nov 22, 2022
@richardyu-ms richardyu-ms deleted the fix_saiserverv2 branch January 16, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants