[Cherry-pick]Remove PYTHON_THRIFT_0_14_1 (#12169)#12782
Closed
richardyu-ms wants to merge 1 commit intosonic-net:masterfrom
Closed
[Cherry-pick]Remove PYTHON_THRIFT_0_14_1 (#12169)#12782richardyu-ms wants to merge 1 commit intosonic-net:masterfrom
richardyu-ms wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]>
Gfrom2016
approved these changes
Nov 21, 2022
Contributor
Author
|
close this one, as there is a fix from the root cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PYTHON_THRIFT_0_14_1 couldn't be built on the pipeline which caused building docker-saiserverv2 to be failed.
cause the PYTHON_THRIFT_0_14_1 is not built as previous thrift_0.11 for python2.*
for thrift 0.11
https://github.com/sonic-net/sonic-buildimage/blob/master/src/thrift/Makefile#L5
For thrift 0.14
https://github.com/sonic-net/sonic-buildimage/blob/master/src/thrift_0_14_1/Makefile#L5
when build this target, there will be an error
Cause no build target depends on
PYTHON_THRIFT_0_14_1, remove this target from buildHow I did it
Remove PYTHON_THRIFT_0_14_1 from rules/thrift_0_14_1.mk.
How to verify it
Run pipeline internally and docker-saiserverv2 is built successfully.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)