Fix code irregular issues#12595
Merged
lixiaoyuner merged 2 commits intosonic-net:masterfrom Nov 7, 2022
Merged
Conversation
Signed-off-by: Yun Li <[email protected]>
|
This pull request introduces 1 alert when merging 506b694 into b3a8167 - view on LGTM.com new alerts:
|
qiluo-msft
approved these changes
Nov 5, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Fix code irregular issues Signed-off-by: Yun Li <[email protected]>
Collaborator
|
@lixiaoyuner PR conflicts with 202205 branch |
lixiaoyuner
added
Approved for 202205 Branch
and removed
Cherry Pick Conflict_202205
Approved for 202205 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 4, 2022
* Fix code irregular issues Signed-off-by: Yun Li <[email protected]>
Collaborator
|
Cherry-pick PR to 202205: #12934 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yun Li [email protected]
Why I did it
This PR is together with this pre-PR #12188, Qi has some comments after the pre-PR merged, mainly remove the comment code line, didn’t change real functional code in this PR
How I did it
Change the code per Qi's comments
How to verify it
Call the python function without value on the parameter whose default value is None
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)