Clear /etc/resolv.conf before building image#12592
Merged
yxieca merged 5 commits intosonic-net:masterfrom Nov 10, 2022
devpatha:master
Merged
Clear /etc/resolv.conf before building image#12592yxieca merged 5 commits intosonic-net:masterfrom devpatha:master
yxieca merged 5 commits intosonic-net:masterfrom
devpatha:master
Conversation
If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost'
Blueve
reviewed
Nov 7, 2022
Contributor
|
Do we currently have a way of configuring the DNS settings through minigraph or CLI? Also, there are test cases in sonic-mgmt that assume that DNS is properly configured and available. That will need updating. |
yxieca
approved these changes
Nov 9, 2022
Blueve
approved these changes
Nov 10, 2022
saiarcot895
approved these changes
Nov 10, 2022
Contributor
|
Why I did it How I did it How to verify it |
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
Why I did it nameserver and domain entries from build system fsroot gets into sonic image. How I did it Clear /etc/resolv.conf before building image How to verify it Built image with it and verified with install that /etc/resolv.conf is empty
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
7 tasks
Contributor
Author
I created #12686 for 202012. |
Contributor
Merged |
qiluo-msft
added
Included in 202012 Branch
and removed
Request for 202012 Branch
Cherry Pick Conflict_202012
labels
This was referenced Feb 3, 2023
yejianquan
added
the
Request for 202111 Branch
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 17, 2023
Why I did it nameserver and domain entries from build system fsroot gets into sonic image. How I did it Clear /etc/resolv.conf before building image How to verify it Built image with it and verified with install that /etc/resolv.conf is empty
10 tasks
lguohan
pushed a commit
that referenced
this pull request
May 18, 2023
Cherry pick PR#12592 Why I did it nameserver and domain entries from build system fsroot gets into sonic image. How I did it Clear /etc/resolv.conf before building image How to verify it Built image with it and verified with install that /etc/resolv.conf is empty Co-authored-by: Devesh Pathak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
nameserver and domain entries from build system fsroot gets into sonic image.
How I did it
Clear /etc/resolv.conf before building image
How to verify it
Built image with it and verified with install that /etc/resolv.conf is empty
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)