Add a parameter for libsaithrift to skip error on errno -2#12581
Merged
Gfrom2016 merged 1 commit intosonic-net:202205from Nov 3, 2022
Merged
Add a parameter for libsaithrift to skip error on errno -2#12581Gfrom2016 merged 1 commit intosonic-net:202205from
Gfrom2016 merged 1 commit intosonic-net:202205from
Conversation
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
richardyu-ms
approved these changes
Nov 2, 2022
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
Gfrom2016
added a commit
to Gfrom2016/sonic-buildimage
that referenced
this pull request
Nov 7, 2022
…#12581) Signed-off-by: zitingguo-ms <zitingguo@microsoft.com> Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
7 tasks
Contributor
Author
|
This PR could not be cleanly cherry-picked to 202012, submit another PR: #12617 |
richardyu-ms
pushed a commit
that referenced
this pull request
Nov 7, 2022
richardyu-ms
pushed a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Nov 25, 2022
…2012 Merge external github 202012 branch to internal-202012. Includes conflict resolved for caclmgrd during merge Related work items: sonic-net#152, sonic-net#155, sonic-net#12577, sonic-net#12581, sonic-net#12600, sonic-net#12604, sonic-net#12617, sonic-net#12631, sonic-net#12641, sonic-net#12655, sonic-net#12666
Contributor
|
202012 branch PR merged: #12617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add a parameter for building libsaithrift of the Broadcom platform to skip specific error codes.
How I did it
How to verify it
Manually built the libsaithrift package with the new parameter, and run the SAI test case with it.
Test the API that returns SAI_STATUS_NOT_SUPPORTED.
For example, for the Broadcom platform, API sai_thrift_flush_fdb_entries with attribute SAI_FDB_FLUSH_ENTRY_TYPE_STATIC return SAI_STATUS_NOT_SUPPORTED which is -2.
Run tests including this API, and they successfully skip tests with error code -2.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: zitingguo-ms zitingguo@microsoft.com