Skip to content

[FRR]Adding patch to fix enhanced capability turned on for interface#12453

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
dgsudharsan:frr_patch_1
Oct 20, 2022
Merged

[FRR]Adding patch to fix enhanced capability turned on for interface#12453
liat-grozovik merged 1 commit intosonic-net:masterfrom
dgsudharsan:frr_patch_1

Conversation

@dgsudharsan
Copy link
Collaborator

@dgsudharsan dgsudharsan commented Oct 19, 2022

Why I did it

Fixing issue FRRouting/frr#11108
For interface based peers with peer-groups, "no neighbor capability extended-nexthop" gets added by default. This will result in IPv4 routes not having ipv6 next hops.

How I did it

Porting the commit FRRouting/frr@8e89adc to FRR 8.2.2 which fixes the issue

How to verify it

Load FRR and verify if the "no neighbor capability extended-nexthop" not gets added for interfaces associated with peer-groups

Before fix

show running-config
Building configuration...

Current configuration:
!
frr version 8.2.2
frr defaults traditional
hostname r-lionfish-16
no service integrated-vtysh-config
!
router bgp 65001
 no bgp suppress-duplicates
 neighbor PEER_V6 peer-group
 neighbor PEER_V6 remote-as internal
 neighbor PEER_V6 capability extended-nexthop
 neighbor Ethernet116 interface peer-group PEER_V6
 no neighbor Ethernet116 capability extended-nexthop
 !
 address-family ipv4 unicast
  redistribute connected
 exit-address-family
 !
exit

After fix

show running-config
Building configuration...

Current configuration:
!
frr version 8.2.2
frr defaults traditional
hostname r-lionfish-16
no service integrated-vtysh-config
!
router bgp 65001
 no bgp suppress-duplicates
 neighbor PEER_V6 peer-group
 neighbor PEER_V6 remote-as internal
 neighbor PEER_V6 capability extended-nexthop
 neighbor Ethernet116 interface peer-group PEER_V6
 !
 address-family ipv4 unicast
  redistribute connected
 exit-address-family
 !
exit

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@prsunny
Copy link
Contributor

prsunny commented Oct 19, 2022

@StormLiangMS for viz

@dgsudharsan
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 2f49062 into sonic-net:master Oct 20, 2022
yxieca pushed a commit that referenced this pull request Oct 25, 2022
…12453)

Fixing issue FRRouting/frr#11108
For interface based peers with peer-groups, "no neighbor capability extended-nexthop" gets added by default. This will result in IPv4 routes not having ipv6 next hops.

- How I did it
Porting the commit FRRouting/frr@8e89adc to FRR 8.2.2 which fixes the issue

- How to verify it
Load FRR and verify if the "no neighbor capability extended-nexthop" not gets added for interfaces associated with peer-groups
@dgsudharsan dgsudharsan deleted the frr_patch_1 branch March 9, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants