Fix to improve hostname handling#12064
Merged
yxieca merged 2 commits intosonic-net:masterfrom Oct 25, 2022
devpatha:master
Merged
Fix to improve hostname handling#12064yxieca merged 2 commits intosonic-net:masterfrom devpatha:master
yxieca merged 2 commits intosonic-net:masterfrom
devpatha:master
Conversation
If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost'
|
|
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12064 in repo sonic-net/sonic-buildimage |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12064 in repo sonic-net/sonic-buildimage |
yxieca
reviewed
Oct 13, 2022
yxieca
approved these changes
Oct 24, 2022
yxieca
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Fix to improve hostname handling If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost' * default hostname to 'sonic` if missing in config file
yxieca
pushed a commit
that referenced
this pull request
Oct 25, 2022
* Fix to improve hostname handling If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost' * default hostname to 'sonic` if missing in config file
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Fix to improve hostname handling If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost' * default hostname to 'sonic` if missing in config file
abdosi
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Fix to improve hostname handling If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost' * default hostname to 'sonic` if missing in config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost'
How I did it
If hostname is not available from config_db.json, do not edit /etc/hostname and exit
How to verify it
with missing hostname entry in config_db.json, /etc/hostname entry is not cleared
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)