01.Version-cache - restructuring of Makefile.work#12000
01.Version-cache - restructuring of Makefile.work#12000qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
- The Makefile.work becomes complex and it is very difficult to manage the changes across branches. - Restructured the Makefile.work and it becomes more readable. - Added $(QUIET) option to turn on command echo mode through command line option. - Exported the SONIC_BUILD_VARS variable, through which make options can be set dynamically. Eg: make SONIC_BUILD_VARS='INCLUDE_NAT=y'
Kalimuthu-Velappan
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12000 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12000 in repo sonic-net/sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 12000 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@xumia @liushilongbuaa submitter has taken the time to split the original code PR to smaller submissions for review, pls help review and merge |
This reverts commit c691b73.
| .DEFAULT_GOAL := all | ||
|
|
||
| %:: | ||
| %:: | sonic-build-hooks |
There was a problem hiding this comment.
There is no dependency check for the sonic-build-hooks target, so we are checking this target always.
|
I tried the below commands, but it doesn't generate the expected out file in the host. #cat Dockerfile FROM scratch AS export-stage #docker build --no-cache -o out . |
Why I did it make clean is broken after #12000: bash: -c: line 1: syntax error near unexpected token `;' bash: -c: line 1: `make -f slave.mk PLATFORM= PLATFORM_ARCH=amd64 MULTIARCH_QEMU_ENVIRON=n ... MIRROR_URLS= MIRROR_SECURITY_URLS= Q=@ clean; ; ' make[1]: *** [Makefile.work:531: clean] Error 2 How I did it Remove a conditional for clean command. Signed-off-by: Konstantin Vasin <[email protected]>
|
@Kalimuthu-Velappan PR conflicts with 202211 branch |
7 participants
Eg: make SONIC_BUILD_VARS='INCLUDE_NAT=y'
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)