[actions] Add github context env in label action.#11926
Merged
liushilongbuaa merged 1 commit intosonic-net:masterfrom Sep 2, 2022
Merged
[actions] Add github context env in label action.#11926liushilongbuaa merged 1 commit intosonic-net:masterfrom
liushilongbuaa merged 1 commit intosonic-net:masterfrom
Conversation
xumia
reviewed
Sep 2, 2022
| @@ -23,6 +23,8 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: approve | |||
Collaborator
There was a problem hiding this comment.
The approval step should be in another action, right?
Contributor
Author
There was a problem hiding this comment.
It is the same trigger. Maybe we can change the file name from label.yml to label_approve.yml
xumia
approved these changes
Sep 2, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 2, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 2, 2022
11 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 29, 2023
Why I did it Cherry-Pick #11926 into 202012 Work item tracking Microsoft ADO (17850717): How I did it Create patch file to avoid notify race between io and main pthreads. How to verify it PR test, physical DUT for bgp related regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
GITHUB_CONTEXT didn't been passed to label action.
PR approval failed.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)