Skip to content

yang model table DEVICE_NEIGHBOR_METADATA creation#11894

Merged
jcaiMR merged 3 commits intosonic-net:masterfrom
jcaiMR:yang/device_neighbor_metadata
Sep 13, 2022
Merged

yang model table DEVICE_NEIGHBOR_METADATA creation#11894
jcaiMR merged 3 commits intosonic-net:masterfrom
jcaiMR:yang/device_neighbor_metadata

Conversation

@jcaiMR
Copy link
Copy Markdown
Contributor

@jcaiMR jcaiMR commented Aug 30, 2022

Why I did it

Add support for DEVICE_NEIGHBOR_METADATA yang model table

How I did it

Create new yang files for DEVICE_NEIGHBOR_METADATA , add UT.

How to verify it

Run UT for sonic-yang-models

Which release branch to backport (provide reason below if selected)

  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

fixes #10545

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Aug 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@jcaiMR jcaiMR marked this pull request as draft August 30, 2022 10:52
@qiluo-msft qiluo-msft added the YANG YANG model related changes label Aug 30, 2022
@ganglyu
Copy link
Copy Markdown
Contributor

ganglyu commented Sep 2, 2022

Unit tests for sonic-config-engine failed.

@ganglyu
Copy link
Copy Markdown
Contributor

ganglyu commented Sep 2, 2022

why do you update submodule for frr?

@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 2, 2022

/easycla

@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 2, 2022

why do you update submodule for frr?

Thanks for point this out, it's a miss op by commit, I will move it our.

@jcaiMR jcaiMR closed this Sep 2, 2022
@jcaiMR jcaiMR reopened this Sep 2, 2022
@yejianquan
Copy link
Copy Markdown
Contributor

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Contributor

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR jcaiMR marked this pull request as ready for review September 2, 2022 14:25
@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 5, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 5, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jcaiMR jcaiMR requested review from ganglyu and qiluo-msft September 6, 2022 14:49
@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 6, 2022

Latest build failure introduced by https://github.com/sonic-net/sonic-buildimage/pull/ 11848, owner is working on fix.

@jcaiMR
Copy link
Copy Markdown
Contributor Author

jcaiMR commented Sep 7, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Copy Markdown
Contributor

liushilongbuaa commented May 11, 2023

@yxieca , the original repo has some issue. Here is the response from github:

I have been updated that the affected pull request did not run because the forked repository was duplicated on the 29th of March 2023 and the first one was marked as inactive.

The pull request was from the first inactive repository, so the pull request points to a repository ID that doesn't exist, because it somehow was recreated.

As you mentioned you won't experience this issue from other forked repositories, but if you have other PRs from the same repository from before March 29, they might run into the same issue. Otherwise other pull requests from the repository should run as expected.

@liushilongbuaa
Copy link
Copy Markdown
Contributor

@StormLiangMS , @yxieca , for this PR, auto cherry pick flow didn't work.
If feature is needed please manually cherry pick

yxieca pushed a commit to yxieca/sonic-buildimage that referenced this pull request May 11, 2023
* yang mode support for neighbor metadata

* add description in leaf node

* modify description
yxieca added a commit that referenced this pull request May 12, 2023
* yang mode support for neighbor metadata

* add description in leaf node

* modify description

Co-authored-by: jcaiMR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[yang] Need Yang for DEVICE_NEIGHBOR_METADATA table

7 participants