Skip to content

[device/quanta] Mitigation for security vulnerability #11867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maipbui merged 13 commits into from
Oct 19, 2022
Merged

[device/quanta] Mitigation for security vulnerability #11867

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5df03f9
Mitigate security in subprocess
maipbui Aug 29, 2022
a2a94a6
Add more arguments
maipbui Aug 29, 2022
ab31cfe
Fix args to make subprocess work
maipbui Aug 30, 2022
78df48c
Add args
maipbui Aug 30, 2022
02c79f0
Convert cmd string to cmd array
maipbui Aug 30, 2022
96488b4
Use with
maipbui Sep 1, 2022
ddf291c
Fix p2 returncode
maipbui Sep 2, 2022
85cd030
Add p1 returncode
maipbui Sep 7, 2022
b2f432b
Replace unsafe funcs in platform
maipbui Sep 19, 2022
a6453a5
Restore deleted text
maipbui Sep 19, 2022
ba7a4be
Change run to call and use common lib
maipbui Oct 5, 2022
62c4237
Fix lgtm
maipbui Oct 17, 2022
e521b22
Fix PR comments
maipbui Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions device/quanta/x86_64-quanta_ix1b_rglbmc-r0/plugins/psuutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import os.path
import subprocess
import logging
from shlex import split

try:
from sonic_psu.psu_base import PsuBase
Expand All @@ -24,9 +25,12 @@ def show_log(txt):

def exec_cmd(cmd, show):
logging.info('Run :'+cmd)
in_cmd = cmd.split('>')[0]
out_file = cmd.split('>')[1].strip()
try:
output = subprocess.check_output(cmd, shell=True, universal_newlines=True)
show_log(cmd + "output:"+str(output))
with open(out_file, 'w') as f:
output = subprocess.run(split(in_cmd), universal_newlines=True, check=True).stdout
show_log(cmd + "output:"+str(output))
except subprocess.CalledProcessError as e:
logging.info("Failed :"+cmd)
if show:
Expand All @@ -44,8 +48,15 @@ def log_os_system(cmd, show):
logging.info('Run :'+cmd)
status = 1
output = ""
cmd1 = split(cmd.split('|')[0].rstrip())
cmd2 = split(cmd.split('|')[1].lstrip())
try:
output = subprocess.check_output(cmd, shell=True, universal_newlines=True)
p1 = subprocess.Popen(cmd1, universal_newlines=True, stdout=subprocess.PIPE)
p2 = subprocess.Popen(cmd2, universal_newlines=True, stdin=p1.stdout, stdout=subprocess.PIPE)
p1.stdout.close()
output = p2.communicate()[0]
if p2.returncode == 1:
raise subprocess.CalledProcessError(returncode=p2.returncode, cmd=cmd, output=output)
my_log(cmd + "output:"+str(output))
except subprocess.CalledProcessError as e:
logging.info('Failed :'+cmd)
Expand Down