Skip to content

[device/juniper] Mitigation for security vulnerability #11838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maipbui merged 19 commits into from
Nov 22, 2022
Merged

[device/juniper] Mitigation for security vulnerability #11838

Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
04d7d16
Replace subprocess getstatusoutput by run
maipbui Aug 24, 2022
fba2445
Fix var name
maipbui Aug 24, 2022
e783a42
Add capture_output and minimize code change
maipbui Aug 24, 2022
25af1be
Remove unused variable
maipbui Aug 24, 2022
954c0da
Add more args
maipbui Aug 29, 2022
83d60d5
Remove center directory
maipbui Aug 31, 2022
f380aae
Remove os.system
maipbui Aug 31, 2022
2fa4ded
Remove shutil and use subprocess and with
maipbui Sep 1, 2022
109303e
Use with
maipbui Sep 1, 2022
d40d086
Simplify code
maipbui Sep 1, 2022
b44a588
Fix lgtm
maipbui Sep 1, 2022
a000b35
Output text processing
maipbui Sep 7, 2022
9acf59c
Replace unsafe funcs in platform
maipbui Sep 19, 2022
e667990
Fix lgtm
maipbui Sep 19, 2022
37496d4
Fix PR comments
maipbui Oct 5, 2022
b53376c
Merge remote-tracking branch 'upstream/master' into juniper_security
maipbui Oct 5, 2022
59ce323
Fix lgtm
maipbui Oct 17, 2022
fb8b24f
Fix code to be consistent with original behavior
maipbui Nov 18, 2022
2b45169
fix lgtm
maipbui Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions device/juniper/x86_64-juniper_qfx5200-r0/plugins/qfx5200_eeprom_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,11 @@
# components is subject to the terms and conditions of the respective license
# as noted in the Third-Party source code file.

import binascii
import os
import sys
import binascii
import subprocess
from sonic_eeprom import eeprom_tlvinfo

if sys.version_info[0] < 3:
import commands
else:
import subprocess as commands


def fantype_detect():

Expand All @@ -56,9 +51,8 @@ def fantype_detect():
for filename in os.listdir(refpgaTMC_path):
if filename.endswith('_type'):
fantype_path = os.path.join(refpgaTMC_path, filename)
cat_string = "cat "
fantype_string = cat_string + fantype_path
status, fan_type = commands.getstatusoutput(fantype_string)
p = subprocess.run(["cat", fantype_path], capture_output=True, universal_newlines=True)
fan_type = p.stdout
if ((fan_type == AFO) or (fan_type == AFI)):
return fan_type
else:
Expand Down