Revert "[arm] Refactor installer and build to allow arm builds targeted at grub platforms"#11599
Closed
qiluo-msft wants to merge 1 commit intomasterfrom
Closed
Revert "[arm] Refactor installer and build to allow arm builds targeted at grub platforms"#11599qiluo-msft wants to merge 1 commit intomasterfrom
qiluo-msft wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
|
@alexrallen Please help check. You may redo your original PR after this revert. |
xumia
approved these changes
Aug 1, 2022
alexrallen
suggested changes
Aug 1, 2022
Contributor
alexrallen
left a comment
There was a problem hiding this comment.
What is the reasoning of this revert? The PR description fails to justify such a measure.
-
I don't see how a revert is justified by non-functional code organization issues. While I would have preferred any issues with the file extensions / organization to be reported with the original PR I do not see how this could not be resolved by an additional PR on top of what already exists.
-
Your second point refers to an issue that I am under the impression that is being resolved by another PR (#11572) What additional issues exist that warrant a revert?
Collaborator
Author
|
Close this in favor of #11572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11341
Why I did it
The original PR has some issues [arm] Refactor installer and build to allow arm builds targeted at grub platforms #11341 (comment)
The %%EXTRA_CMDLINE_LINUX%% is not replaced to the real value, it has impact on the kernel parameter settings.
See the log sonic-vs.img.gz.log in the latest master build. In the grub.cfg, the %%EXTRA_CMDLINE_LINUX%% is set in the linux command line.