Update sonic-frr submodule to FRR 8.2.2

[hasan-brcm]

Why I did it

The sonic-frr was upgraded to FRR 8.2.2 as part of PR #10691. However, sonic-frr/frr submodule was still referring to previous 7.5 version. Update the sonic-frr/frr submodule to 8.2.2 commit id. Fixes issue #11484.

How I did it

• checkout FRR 8.2.2 commit id 79188bf in sonic-frr/frr
• commit and push

How to verify it

• build and load

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205

Description for the changelog

Update sonic-frr/frr submodule to frr 8.2.2 commit 79188bf

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[DavidZagury]

It should also be backported to 202205

[zhangyanzhao]

Need merge this issue for 202205.

[dgsudharsan]

I went through the list of patches that were removed in the FRR upgrade #10691.

There is one patch of concern.

src/sonic-frr/patch/0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch

In FRR
Introduced: sonic-net/sonic-frr@0b6d353

Reverted: sonic-net/sonic-frr@6740a19 (FRRouting/frr#8430)

However, this patch was introduced in SONiC but never reverted. Now with upgrading to FRR and without this patch won’t we be facing issues?

[hasan-brcm]

I went through the list of patches that were removed in the FRR upgrade #10691.

There is one patch of concern.

src/sonic-frr/patch/0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch

In FRR Introduced: sonic-net/sonic-frr@0b6d353

Reverted: sonic-net/sonic-frr@6740a19 (FRRouting/frr#8430)

However, this patch was introduced in SONiC but never reverted. Now with upgrading to FRR and without this patch won’t we be facing issues?

Please note that patch file 0009-Link-local-scope.. has been replaced with 0008-Link-local-scope..:

Regarding the changes in the old 0009-Link-local-scope patch file, there were two changes originally. One of the changes (in bgp_update_address()) has been carried to the new patch file, and the other change (in bgp_zebra_nexthop_set()) is already present in the 8.2.2 code. I hope this clarifies.

[adyeung]

/easycla

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: hasan-brcm / name: Hasan Naqvi (35b89c9)

[dgsudharsan]

Thanks for your explanation. However I see the changes in patch 0008-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch are not in upstream FRR since they were reverted. I am not sure if SONiC would allow patches that are not in upstream. @lguohan @prsunny @abdosi can you please provide feedback here?

[liat-grozovik]

@prsunny could you please help to review prev comment? As 202205 should include the new frr version I believe we need to push this with high prio. If fix still need to be done let's close the gap