Revert "Update include_macsec flag if type is SpineRouter (#11141)"#11306
Merged
judyjoseph merged 1 commit intomasterfrom Jul 1, 2022
Merged
Revert "Update include_macsec flag if type is SpineRouter (#11141)"#11306judyjoseph merged 1 commit intomasterfrom
judyjoseph merged 1 commit intomasterfrom
Conversation
This reverts commit c9f3695.
arlakshm
approved these changes
Jul 1, 2022
yxieca
pushed a commit
that referenced
this pull request
Jul 5, 2022
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
…11141)" (sonic-net#11306) This reverts commit c9f3695.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR #11141 introduced the template specific check for macsec feature to be enabled if 'type' is 'SpineRouter'. The rendering of init_cfg.json.j2 file is done by hostcfgd daemon.
Currently hostcfgd does update the feature state by template rendering only only in host config db. This fix was earlier verified only on single asic platforms.
Close issue #11302
How I did it
Removed the earlier fix and setting macsec to be disabled by default. Need to explicitly enable.
Will plan to bring this change in along with fixes in hostcfgd to update the feature state after rendeding in namespace config_db also. Need more testing in hostcfgd to add full namespace support there
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)