Skip to content

Avoid write_standby in warm restart context #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zjswhhh merged 2 commits into from
Jun 30, 2022
Merged

Avoid write_standby in warm restart context #11283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7fb882
check warmrestart context
zjswhhh Jun 29, 2022
18b0cbf
update log wording
zjswhhh Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions files/scripts/write_standby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import time

from sonic_py_common import logger as log
from swsscommon.swsscommon import ConfigDBConnector, DBConnector, FieldValuePairs, ProducerStateTable, SonicV2Connector
from swsscommon.swsscommon import APPL_DB
from swsscommon.swsscommon import ConfigDBConnector, DBConnector, FieldValuePairs, ProducerStateTable, SonicV2Connector, Table
from swsscommon.swsscommon import APPL_DB, STATE_DB

logger = log.Logger('write_standby')

Expand All @@ -22,6 +22,7 @@ class MuxStateWriter(object):
def __init__(self):
self.config_db_connector = None
self.appl_db_connector = None
self.state_db_connector = None
self.asic_db_connector = None

@property
Expand All @@ -45,6 +46,16 @@ def appl_db(self):
if self.appl_db_connector is None:
self.appl_db_connector = DBConnector(APPL_DB, REDIS_SOCK_PATH, True)
return self.appl_db_connector

@property
def state_db(self):
"""
Returns the state DB connector.
Intializes the connector during the first call
"""
if self.state_db_connector is None:
self.state_db_connector = DBConnector(STATE_DB, REDIS_SOCK_PATH, True)
return self.state_db_connector

@property
def asic_db(self):
Expand Down Expand Up @@ -75,6 +86,16 @@ def is_dualtor(self):

return 'subtype' in metadata and 'dualtor' in metadata['subtype'].lower()

@property
def is_warmrestart(self):
"""
Checks if a warmrestart is going on
"""
tbl = Table(self.state_db, 'WARM_RESTART_ENABLE_TABLE')
(status, value) = tbl.hget('system', 'enable')

return status and value == 'true'

def get_auto_mux_intfs(self):
"""
Returns a list of all mux cable interfaces that are configured to auto-switch
Expand Down Expand Up @@ -117,6 +138,12 @@ def apply_mux_config(self):
if not self.is_dualtor:
# If not running on a dual ToR system, take no action
return

if self.is_warmrestart:
# If in warmrestart context, take no action
logger.log_warning("Skip setting mux state due to ongoing warmrestart.")
return

intfs = self.get_auto_mux_intfs()
state = 'standby'
if self.wait_for_tunnel():
Expand Down