[202012] [cherry-pick] Add extra lossy PG profile for ports between T1 and T2#11160
Closed
bingwang-ms wants to merge 2 commits intosonic-net:202012from
Closed
[202012] [cherry-pick] Add extra lossy PG profile for ports between T1 and T2#11160bingwang-ms wants to merge 2 commits intosonic-net:202012from
bingwang-ms wants to merge 2 commits intosonic-net:202012from
Conversation
Signed-off-by: bingwang <[email protected]>
lguohan
approved these changes
Jun 16, 2022
Contributor
|
@bingwang-ms, do we still need this PR. Weren't these changes included in #11132? |
Signed-off-by: bingwang <[email protected]>
Contributor
Author
|
Change already included in #11132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR is to cherry-pick #11157 to
202012branch after resolving conflicts.This PR brings two changes
PG2andPG6on T1 for ports between T1 and T2.After PR Update qos config to clear queues for bounced back traffic #10176 , the
DSCP_TO_TC_MAPandTC_TO_PG_MAPis updated when remapping is enableSo, we have two new lossy PGs (2 and 6) for the T2 facing ports on T1, and two new lossless PGs (2 and 6) for the T0 facing port on T1.
However, there is no lossy PG profile for the T2 facing ports on T1. The lossless PGs for ports between T1 and T0 have been handled by
buffermgrd.Therefore, We need to add lossy PG profiles for T2 facing ports on T1.We don't have this issue on T0 because
PG 2andPG 6are lossless PGs, and there is no lossy traffic mapped toPG 2andPG 6TC7toPG0Before the PCBB change,
DSCP48 -> TC 6 -> PG 0.After the PCBB change,
DSCP48 -> TC 7 -> PG 7Actually, we can map
TC7toPG0to save a lossy PG.How I did it
Update the qos and buffer template.
How to verify it
Verified by UT.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)