[build] Add dependencies for sonic-config-engine to block bad PR.#10770
Merged
liushilongbuaa merged 2 commits intosonic-net:masterfrom May 7, 2022
Merged
Conversation
liushilongbuaa
added
Build
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
qiluo-msft
approved these changes
May 6, 2022
xumia
approved these changes
May 7, 2022
Contributor
|
@liushilongbuaa Please raise a separate PR for 202111 as there are conflicts |
judyjoseph
removed
the
Request for 202111 Branch
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2022
…nic-net#10770) Add dependencies device/*
This was referenced May 10, 2022
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 25, 2022
…nic-net#10770) Add dependencies device/*
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 7, 2022
…nic-net#10770) Add dependencies device/*
6 tasks
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 7, 2022
…nic-net#10770) Add dependencies device/*
6 tasks
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
…nic-net#10770) Add dependencies device/*
Contributor
|
202012 branch PR merged: #11054 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
PR validation will use cached package to bypass PR validation.
How I did it
Add dependencies 'device/*' for sonic-config-engine to block bad PR.
It will reduce cache hit rate but increase build success rate.
How to verify it
check PR calidation dependency file.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)