Skip to content

[build]: add sonic-config-engine to sonic-utilitie build dependency #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
Oct 25, 2017
Merged

[build]: add sonic-config-engine to sonic-utilitie build dependency #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rules/sonic-utilities.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

SONIC_UTILS = python-sonic-utilities_1.1-1_all.deb
$(SONIC_UTILS)_SRC_PATH = $(SRC_PATH)/sonic-utilities
$(SONIC_UTILS)_WHEEL_DEPENDS = $(SONIC_CONFIG_ENGINE)
Copy link
Copy Markdown
Contributor

@taoyl-ms taoyl-ms Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add dependency to swsssdk?

Copy link
Copy Markdown
Collaborator Author

@lguohan lguohan Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swsssdk is the config-engine dependency, no need to explicit specify that. Check the build log below.

lgh@ba2755a9022e:/data/sonic/sonic-buildimage$ make -f slave.mk  target/debs/python-sonic-utilities_1.1-1_all.deb        
SONiC Build System

Build Configuration
"CONFIGURED_PLATFORM"             : "vs"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_CONFIG_BUILD_JOBS"         : "1"
"SONIC_CONFIG_MAKE_JOBS"          : "4"
"DEFAULT_USERNAME"                : "admin"
"DEFAULT_PASSWORD"                : "YourPaSsWoRd"
"ENABLE_DHCP_GRAPH_SERVICE"       : ""
"SHUTDOWN_BGP_ON_START"           : ""
"SONIC_CONFIG_DEBUG"              : ""
"ROUTING_STACK"                   : "quagga"
"ENABLE_SYNCD_RPC"                : ""
"ENABLE_ORGANIZATION_EXTENSIONS"  : "y"

[ building ] [ target/python-wheels/swsssdk-2.0.1-py2-none-any.whl ] 
[ finished ] [ target/python-wheels/swsssdk-2.0.1-py2-none-any.whl ] 
[ building ] [ target/python-wheels/swsssdk-2.0.1-py2-none-any.whl-install ] 
[ finished ] [ target/python-wheels/swsssdk-2.0.1-py2-none-any.whl-install ] 
[ building ] [ target/python-wheels/sonic_config_engine-1.0-py2-none-any.whl ] 
[ finished ] [ target/python-wheels/sonic_config_engine-1.0-py2-none-any.whl ] 
[ building ] [ target/python-wheels/sonic_config_engine-1.0-py2-none-any.whl-install ] 
[ finished ] [ target/python-wheels/sonic_config_engine-1.0-py2-none-any.whl-install ] 
[ building ] [ target/debs/python-sonic-utilities_1.1-1_all.deb ] 
[ finished ] [ target/debs/python-sonic-utilities_1.1-1_all.deb ]

SONIC_PYTHON_STDEB_DEBS += $(SONIC_UTILS)
3 changes: 2 additions & 1 deletion slave.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ SONIC_TARGET_LIST += $(addprefix $(DEBS_PATH)/, $(SONIC_DPKG_DEBS))
# $(SOME_NEW_DEB)_SRC_PATH = $(SRC_PATH)/project_name
# $(SOME_NEW_DEB)_DEPENDS = $(SOME_OTHER_DEB1) $(SOME_OTHER_DEB2) ...
# SONIC_PYTHON_STDEB_DEBS += $(SOME_NEW_DEB)
$(addprefix $(DEBS_PATH)/, $(SONIC_PYTHON_STDEB_DEBS)) : $(DEBS_PATH)/% : .platform $$(addsuffix -install,$$(addprefix $(DEBS_PATH)/,$$($$*_DEPENDS)))
$(addprefix $(DEBS_PATH)/, $(SONIC_PYTHON_STDEB_DEBS)) : $(DEBS_PATH)/% : .platform $$(addsuffix -install,$$(addprefix $(DEBS_PATH)/,$$($$*_DEPENDS))) \
$$(addsuffix -install,$$(addprefix $(PYTHON_WHEELS_PATH)/,$$($$*_WHEEL_DEPENDS)))
$(HEADER)
# Apply series of patches if exist
if [ -f $($*_SRC_PATH).patch/series ]; then pushd $($*_SRC_PATH) && QUILT_PATCHES=../$(notdir $($*_SRC_PATH)).patch quilt push -a; popd; fi
Expand Down