Skip to content

[initramfs]: SSD firmware upgrade in initramfs #10748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sujinmkang merged 1 commit into from
May 12, 2022
Merged

[initramfs]: SSD firmware upgrade in initramfs #10748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/arista-
sudo cp files/initramfs-tools/resize-rootfs $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/resize-rootfs
sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/resize-rootfs

# Hook into initramfs: upgrade SSD from initramfs
sudo cp files/initramfs-tools/ssd-upgrade $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/ssd-upgrade
sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/ssd-upgrade

# Hook into initramfs: run fsck to repair a non-clean filesystem prior to be mounted
sudo cp files/initramfs-tools/fsck-rootfs $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/fsck-rootfs
sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-premount/fsck-rootfs
Expand Down
3 changes: 3 additions & 0 deletions files/image_config/platform/rc.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ migrate_nos_configuration()
# remove nos-config-part from cmdline
sed -r -i.bak "s/nos-config-part=[^[:space:]]+//" /host/grub/grub.cfg

# remove ssd-upgrader-part from cmdline
Copy link
Contributor

@lizhuhuams lizhuhuams May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment here to show what exactly the string replacement is?

Copy link
Contributor Author

@ArunSaravananBalachandran ArunSaravananBalachandran May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this command, the ssd-upgrader-part option is completely removed from the command line (replaced with an empty string) similar to nos-config-part.
Please let me know if the comment has to updated with 'empty string' in place of 'remove'.

Copy link
Contributor

@lizhuhuams lizhuhuams May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, current comment matches the ode, then I am fine with it.

sed -r -i.bak "s/ssd-upgrader-part=[^[:space:]]+//" /host/grub/grub.cfg

# Mount the previous NOS's partition
NOS_DIR=/mnt/nos_migration
MG_GZFILE=$NOS_DIR/minigraph.xml.gz.base64.txt
Expand Down
35 changes: 35 additions & 0 deletions files/initramfs-tools/ssd-upgrade
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/sh

case $1 in
prereqs)
exit 0
;;
esac

# Extract kernel parameters
set -- $(cat /proc/cmdline)
for x in "$@"; do
case "$x" in
ssd-upgrader-part=*)
ssd_upgrader_part="${x#ssd-upgrader-part=}"
;;
esac
done

if [ ! -z "$ssd_upgrader_part" ]; then
echo "ssd-upgrader-part found in /proc/cmdline" > /tmp/ssd-fw-upgrade.log
mkdir -p /mnt/ssd_upgrader_part
mount -t "${ssd_upgrader_part#*,}" "${ssd_upgrader_part%,*}" /mnt/ssd_upgrader_part
if [ -x /mnt/ssd_upgrader_part/ssd-fw-upgrade ]; then
cp /mnt/ssd_upgrader_part/ssd-fw-upgrade /tmp/
cd /tmp/
umount /mnt/ssd_upgrader_part
rm -r /mnt/ssd_upgrader_part
./ssd-fw-upgrade >> /tmp/ssd-fw-upgrade.log 2>&1
else
echo "ssd-fw-upgrade not found" >> /tmp/ssd-fw-upgrade.log
umount /mnt/ssd_upgrader_part
rm -r /mnt/ssd_upgrader_part
fi
gzip /tmp/ssd-fw-upgrade.log
fi
5 changes: 5 additions & 0 deletions files/initramfs-tools/union-mount.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,3 +190,8 @@ fi
if [ -f /tmp/fsck.log.gz ]; then
mv /tmp/fsck.log.gz ${rootmnt}/var/log
fi

## ssd-fw-upgrade log file: /tmp will be lost when overlayfs is mounted
if [ -f /tmp/ssd-fw-upgrade.log.gz ]; then
mv /tmp/ssd-fw-upgrade.log.gz ${rootmnt}/var/log
fi