[DellEMC][201911] S6100 CPLD upgrade support in 201911 branch porting changes#10686
Merged
sujinmkang merged 1 commit intosonic-net:201911from Apr 28, 2022
Merged
Conversation
sujinmkang
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The following changes have been made as part of the binary:
If a device contains a chipset that does not require CPLD upgrade, the upgrade will not be done and the consequent reboot will be a normal reboot. The reason for not upgrading will be logged.
Script log messages will be directed to syslog server in addition to logging on console.
By default, if the CPLD upgrade fails the upgrade process will be retried twice.
The maximum number of attempts to be made on failure can be configured from outside the binary using the variable “DELL_S6100_CPLD_UPGRADE_ATTEMPTS”.
Maximum attempts to be made can be configured as 2 using the below commands.
root@sonic:~# DELL_S6100_CPLD_UPGRADE_ATTEMPTS=2root@sonic:~# export DELL_S6100_CPLD_UPGRADE_ATTEMPTSHow I did it
How to verify it
To verify use update_firmware.sh script for CPLD upgrade.
Which release branch to backport (provide reason below if selected)
Description for the changelog
On branch 201911-s6100-cpld
Changes to be committed:
(use "git restore --staged ..." to unstage)
new file: device/dell/x86_64-dell_s6100_c2538-r0/s6100_cpld_upgrade
modified: platform/broadcom/sonic-platform-modules-dell/s6100/scripts/platform_reboot_override
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)