[VS] Align threshold mode of zero buffer profile of egress_lossless_pool#10627
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Apr 25, 2022
Merged
Conversation
On vs platform, egress_lossless_pool's mode is static. So the corresponding profile should be of static_th as well. Signed-off-by: Stephen Sun <stephens@nvidia.com>
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Collaborator
Author
|
/azpw run azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
changed the title
Collaborator
Author
|
/azpw run azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neethajohn
reviewed
Apr 22, 2022
Collaborator
|
@stephenxs I believe there are more platforms in VS tests. are they all aligned? should be aligned? |
Collaborator
Author
No. Currently, dynamic buffer is tested with VS platform using this platform only. |
neethajohn
approved these changes
Apr 25, 2022
Collaborator
OK. Let's check if we wish to have dynamic tested on other platforms if at any. Should not block this PR. |
liat-grozovik
approved these changes
Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On vs platform, egress_lossless_pool's mode is static.
So the corresponding profile should be of static_th as well.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)