Run tune2fs during initramfs instead of image install#10536
Merged
saiarcot895 merged 1 commit intosonic-net:masterfrom Apr 12, 2022
Merged
Run tune2fs during initramfs instead of image install#10536saiarcot895 merged 1 commit intosonic-net:masterfrom
saiarcot895 merged 1 commit intosonic-net:masterfrom
Conversation
If it is run during image install, it's not guaranteed that the installation environment will have tune2fs available. Therefore, run it during initramfs instead. Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
approved these changes
Apr 11, 2022
zzhiyuan
reviewed
Apr 11, 2022
Contributor
zzhiyuan
left a comment
There was a problem hiding this comment.
Aboot change looks good. Thanks.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saikrishna Arcot [email protected]
Why I did it
If it is run during image install, it's not guaranteed that the
installation environment will have tune2fs available. Therefore, run it
during initramfs instead.
How I did it
Remove the tune2fs command from the image installation files, and add
it into initramfs, just after the filesystem gets mounted.
How to verify it
Tested on a Arista 7060 running 201911 image, and was able to install and
boot a 202012 branch image with 5% reserved blocks.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)