[202012][services] kill container on stop in warm/fast mode#10511
[202012][services] kill container on stop in warm/fast mode#10511vaibhavhd merged 2 commits intosonic-net:202012from
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak
changed the title
|
These changes LGTM, but there is an error in PR tests on master branch for the corresponding change. I would suggest to RCA those issues to ensure there isn't a risk introduced. |
| @@ -1,84 +0,0 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Do you know why GIT shows that original radv.sh was deleted? Is it because the new script has new permissions (chmod permissions)?
In the same regard, does other sh scripts introduced here have executable permissions? I think that's necessary.
There was a problem hiding this comment.
All have executable permissions. radv.sh and service_mgmt.sh are not the same.
There was a problem hiding this comment.
I understand that they are different files. My minor concern was why GIT shows that original radv.sh was deleted. This usually happens when contents are replaced and permissions are changed.
There was a problem hiding this comment.
@vaibhavhd The content was changed, please check the line SERVICE="radv" and SERVICE="${SCRIPT_NAME%.*}" in service_mgmt.sh
|
I just realized that this PR hasn't run any tests, and the one on master has gone through round of testing and failed. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@stepanblyschak I am not able to merge this as the branch is |
3 participants
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
To optimize stop on warm boot.
How I did it
Added kill for containers
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)