[docker-ptf]: Upgrade scapy to 2.4.5 in docker-ptf#10507
Merged
lguohan merged 1 commit intosonic-net:masterfrom Apr 9, 2022
Merged
[docker-ptf]: Upgrade scapy to 2.4.5 in docker-ptf#10507lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Ze Gan <[email protected]>
5 tasks
ZhaohuiS
added a commit
that referenced
this pull request
Apr 13, 2022
…10537) It upgraded scapy to 2.4.5 in docker-ptf container, after this upgrade, all scripts under ansible/roles/test/files/ptftests will import scapy 2.4.5, some test cases will fail because they are not upgraded accordingly. Reverts #10507 to avoid breaking regression test. This reverts commit 92efc01.
zjswhhh
pushed a commit
to zjswhhh/sonic-mgmt
that referenced
this pull request
Apr 20, 2022
…202012 The PR sonic-net/sonic-buildimage#10507 upgraded scapy to 2.4.5 in docker-ptf container. After this upgrade, all scripts under ansible/roles/test/files/ptftests will import scapy 2.4.5, some test cases will failed because they are not upgraded accordingly. Take dhcp_relay/test_dhcp_relay.py for example, it failed due to "AssertionError: Failed: Discover count of 0 != 4" and "Unknown field option relay_agent_Information". So tag old and worked docker-ptf image(image ID 36a97ea46625) to 202012, update 202012 nightly test to use this docker-ptf image to avoid major failures. ./testbed-cli.sh restart-ptf vms1-t0-3132 password.txt -e ptf_imagetag=202012 It upgraded docker-ptf container successfully. 714408ef7440 acs-repo.corp.microsoft.com:5001/docker-ptf:202012 "/usr/local/bin/supe…" 2 minutes ago Up 2 minutes ptf_vms1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan [email protected]
Why I did it
Existing dataplane tests cannot be tested under MACsec environment due to the traffic under MACsec link is encrypted. So, I will override the dp_poll of ptf to MACsec dp_poll to decrypt the MACsec packets on injected ports (PR: sonic-net/sonic-mgmt#5490). MACsec decryption library depends on scapy 2.4.5.
How I did it
Upgrade scapy library to 2.4.5 by pip.
How to verify it
Check the scapy version in docker-ptf by
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)