Skip to content

[yang] add yang options for Context object#10359

Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom
ayurkiv-nvda:yang_fix_azure
May 2, 2022
Merged

[yang] add yang options for Context object#10359
qiluo-msft merged 1 commit intosonic-net:masterfrom
ayurkiv-nvda:yang_fix_azure

Conversation

@ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Mar 27, 2022 •
edited
Loading

Why I did it

Need to pass LY_CTX_DISABLE_SEARCHDIR_CWD to Context in order to disable automatically searching for schemas in current working directory (which is by default searched automatically)

How I did it

add additional attribute into YANG context

How to verify it

Create some invalid link on switch :

  1. ln -s /usr/abc xxx
  2. run spm list
    --> There should not be these messages:
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ayurkiv-nvda ayurkiv-nvda requested a review from lguohan as a code owner March 27, 2022 15:55
@ayurkiv-nvda ayurkiv-nvda mentioned this pull request Mar 28, 2022
Merged
@ayurkiv-nvda
Copy link
Contributor Author

ayurkiv-nvda commented Mar 30, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

mssonicbld commented Mar 30, 2022

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 30, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@dprital dprital added the Request for 202111 Branch For PRs being requested for 202111 branch label Apr 4, 2022
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 5, 2022

@qiluo-msft could you please help to signoff?

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Apr 5, 2022 •
edited
Loading

Could you explain more of the section "How to verify it"
The path "/usr/abc" is not existing.
What is spm?
You mentioned "LY_CTX_DISABLE_SEARCHDIR_CWD" but it does not appear in code.

@ayurkiv-nvda
Copy link
Contributor Author

ayurkiv-nvda commented Apr 7, 2022 •
edited
Loading

Could you explain more of the section "How to verify it" The path "/usr/abc" is not existing. What is spm? You mentioned "LY_CTX_DISABLE_SEARCHDIR_CWD" but it does not appear in code.

spm in sonic-package-manager
LY_CTX_DISABLE_SEARCHDIR_CWD is used in related PR sonic-net/sonic-utilities#2118

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 10, 2022

@qiluo-msft could you please review following comments above?

@dgsudharsan dgsudharsan added the YANG YANG model related changes label Apr 11, 2022
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 13, 2022

@praveen-li could you please take a look on this PR as well?

@praveen-li
Copy link
Member

praveen-li commented Apr 13, 2022 via email

qiluo-msft
qiluo-msft reviewed Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for other reviewers.

@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Apr 22, 2022

@praveen-li kindly reminder to review this PR

@dgsudharsan dgsudharsan requested a review from praveen-li April 28, 2022 17:06
@qiluo-msft qiluo-msft merged commit 0a6bb3f into sonic-net:master May 2, 2022
judyjoseph pushed a commit that referenced this pull request May 8, 2022
@ayurkiv-nvda @judyjoseph
[yang] add yang options for Context object (#10359)
1334c04 
#### Why I did it
Need to pass LY_CTX_DISABLE_SEARCHDIR_CWD to Context in order to disable automatically searching for schemas in current working directory (which is by default searched automatically)

#### How I did it
add additional attribute into YANG context

#### How to verify it
Create some invalid link on switch :
1) **ln -s /usr/abc xxx**
2) run **spm list**
--> There should not be these messages:
```
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
```
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@ayurkiv-nvda @liushilongbuaa
[yang] add yang options for Context object (sonic-net#10359)
e4dd549 
#### Why I did it
Need to pass LY_CTX_DISABLE_SEARCHDIR_CWD to Context in order to disable automatically searching for schemas in current working directory (which is by default searched automatically)

#### How I did it
add additional attribute into YANG context

#### How to verify it
Create some invalid link on switch :
1) **ln -s /usr/abc xxx**
2) run **spm list**
--> There should not be these messages:
```
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
libyang[1]: Unable to get information about "xxx" file in "/tmp" when searching for (sub)modules (No such file or directory)
```
@ayurkiv-nvda ayurkiv-nvda deleted the yang_fix_azure branch February 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@praveen-li praveen-li Awaiting requested review from praveen-li

Assignees

No one assigned

Labels

Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch YANG YANG model related changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.