[gbsyncd] Support multiple gbsyncd containers in the same SWI#10354
Closed
zzhiyuan wants to merge 1 commit intosonic-net:masterfrom
Closed
[gbsyncd] Support multiple gbsyncd containers in the same SWI#10354zzhiyuan wants to merge 1 commit intosonic-net:masterfrom
zzhiyuan wants to merge 1 commit intosonic-net:masterfrom
Conversation
Currently the only supported gbsyncd container is docker-gbsyncd-credo. This change will allow docker_image_ctl to check the platform gbsyncd configuration file and run the correct version of gbsyncd for that platform. This will enable the support of docker-gbsyncd-broncos in the future.
jimmyzhai
approved these changes
Mar 28, 2022
Contributor
jimmyzhai
left a comment
jimmyzhai
left a comment
There was a problem hiding this comment.
Looks good.
Note: after this, docker image name of gbsyncd must be like docker-gbsyncd-<gbsyncd platform code>.
6 tasks
Contributor
|
I have created a new PR which includes this change: #11154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only supported gbsyncd container is docker-gbsyncd-credo.
This change will allow docker_image_ctl to check the platform gbsyncd
configuration file and run the correct version of gbsyncd for that
platform. This will enable the support of docker-gbsyncd-broncos in the
future.
Why I did it
Some new platforms will require docker-gbsyncd-broncos for their external PHYs. This change will allow non-Credo gbsyncd to be supported.
How I did it
Add a check for gbsyncd.ini to see which gbsyncd the platform needs.
How to verify it
The existing functionalities for gbsyncd-credo are unaffected.
To test adding a new gbsyncd, one can add the build under platform/components.
The method to verify is not included in this change.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)