Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic B… by AmitKaushik7 · Pull Request #10353 · sonic-net/sonic-buildimage

AmitKaushik7 · 2022-03-25T12:05:46Z

…uffer Model

Why I did it

To address #10342 (Yang validation fails when Buffer profiles are configured with "NULL" values)

How I did it

Allowed NULL as valid data for the BUFFER_PG/BUFFER_QUEUE yang models

How to verify it

------------------- Test 1: BUFFER_PG_WRONG_PROFILE_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Invalid value "wrong" in "profile" element.
test_yang_model.py 210 INFO BUFFER_PG_WRONG_PROFILE_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 2: BUFFER_PG_WRONG_PG_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Invalid Buffer PG number
test_yang_model.py 210 INFO BUFFER_PG_WRONG_PG_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 3: BUFFER_PG_NULL_PROFILE_VALUE no failure---------------------
test_yang_model.py 210 INFO BUFFER_PG_NULL_PROFILE_VALUE no failure Passed

test_yang_model.py 150 INFO
------------------- Test 4: BUFFER_QUEUE_WRONG_PORT_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Leafref "/sonic-port:sonic-port/sonic-port:PORT/sonic-port:PORT_LIST/sonic-port:name" of value "wrong" points to a non-existing leaf.
test_yang_model.py 210 INFO BUFFER_QUEUE_WRONG_PORT_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 5: BUFFER_PG_CORRECT_PROFILE_VALUE no failure---------------------
test_yang_model.py 210 INFO BUFFER_PG_CORRECT_PROFILE_VALUE no failure Passed

test_yang_model.py 150 INFO
------------------- Test 6: BUFFER_QUEUE_WRONG_PROFILE_VALUE pattern failure---------------------
test_yang_model.py 210 INFO BUFFER_QUEUE_WRONG_PROFILE_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 7: BUFFER_QUEUE_WRONG_PROFILE_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Invalid value "wrong" in "profile" element.
test_yang_model.py 210 INFO BUFFER_QUEUE_WRONG_PROFILE_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 8: BUFFER_PG_WRONG_PORT_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Leafref "/sonic-port:sonic-port/sonic-port:PORT/sonic-port:PORT_LIST/sonic-port:name" of value "wrong" points to a non-existing leaf.
test_yang_model.py 210 INFO BUFFER_PG_WRONG_PORT_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 9: BUFFER_QUEUE_WRONG_QUEUE_VALUE pattern failure---------------------
test_yang_model.py 189 INFO Invalid Q-index
test_yang_model.py 210 INFO BUFFER_QUEUE_WRONG_QUEUE_VALUE pattern failure Passed

test_yang_model.py 150 INFO
------------------- Test 10: BUFFER_QUEUE_CORRECT_PROFILE_VALUE no failure---------------------
test_yang_model.py 210 INFO BUFFER_QUEUE_CORRECT_PROFILE_VALUE no failure Passed

test_yang_model.py 150 INFO

Which release branch to backport (provide reason below if selected)

Description for the changelog

Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic Buffer Model, added the new Test cases for the same.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…uffer Model

dgsudharsan

Should port related buffer profiles too be considered for NULL? https://github.com/Azure/sonic-buildimage/blob/928261845058a177c4b65ebaf20495e85d48a497/src/sonic-yang-models/yang-models/sonic-buffer-port-egress-profile-list.yang#L47

dgsudharsan · 2022-03-25T15:03:37Z

Should port related buffer profiles too be considered for NULL?

https://github.com/Azure/sonic-buildimage/blob/928261845058a177c4b65ebaf20495e85d48a497/src/sonic-yang-models/yang-models/sonic-buffer-port-egress-profile-list.yang#L47

@stephenxs Can you please comment?

NJ> I believe no

stephenxs · 2022-03-26T03:46:28Z

src/sonic-yang-models/yang-models/sonic-buffer-queue.yang

+                            path "/bpf:sonic-buffer-profile/bpf:BUFFER_PROFILE/bpf:BUFFER_PROFILE_LIST/bpf:name";
+                        }
+                        type string {
+                            pattern "NULL";


The dynamic calculation is supported in BUFFER_PG only.
For BUFFER_QUEUE table, the profile should always be defined in the BUFFER_PROFILE table. So no need to change BUFFER_QUEUE.

@stephenxs Are there other scenarios where NULL buffer profile may be configured apart from Dynamic calculation?

@dgsudharsan Only two:

profile in BUFFER_PG can be NULL, which is covered in this PR

size in BUFFER_POOL is optional, which has been taken into account

stephenxs · 2022-03-26T03:55:15Z

Should port related buffer profiles too be considered for NULL?
https://github.com/Azure/sonic-buildimage/blob/928261845058a177c4b65ebaf20495e85d48a497/src/sonic-yang-models/yang-models/sonic-buffer-port-egress-profile-list.yang#L47

@stephenxs Can you please comment?

NJ> I believe no

No need to support NULL in either BUFFER_PORT_xxGRESS_PROFILE_LIST or BUFFER_QUEUE. It should be supported in BUFFER_PG only.

qiluo-msft · 2022-03-31T17:15:33Z

@neethajohn Could you check again?

dgsudharsan · 2022-03-31T17:21:37Z

@qiluo-msft @neethajohn Can we merge this?

#10353) Why I did it To address #10342 (Yang validation fails when Buffer profiles are configured with "NULL" values)

Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic B…

b82030e

…uffer Model

AmitKaushik7 requested a review from qiluo-msft as a code owner March 25, 2022 12:05

AmitKaushik7 mentioned this pull request Mar 25, 2022

Yang validation fails when Buffer profiles are configured with "NULL" values #10342

Closed

dgsudharsan added the YANG YANG model related changes label Mar 25, 2022

dgsudharsan requested review from dgsudharsan and stephenxs March 25, 2022 15:00

dgsudharsan requested changes Mar 25, 2022

View reviewed changes

neethajohn previously approved these changes Mar 25, 2022

View reviewed changes

stephenxs reviewed Mar 26, 2022

View reviewed changes

Reverted back Buffer Queue Yang changes & related tests

caa95b0

AmitKaushik7 dismissed neethajohn’s stale review via caa95b0 March 28, 2022 04:24

dgsudharsan added the Request for 202111 Branch For PRs being requested for 202111 branch label Mar 28, 2022

dgsudharsan approved these changes Mar 28, 2022

View reviewed changes

Merge branch 'Azure:master' into buf_profile_NULL

29ccc13

stephenxs approved these changes Mar 30, 2022

View reviewed changes

dgsudharsan requested a review from neethajohn March 31, 2022 17:15

neethajohn approved these changes Mar 31, 2022

View reviewed changes

neethajohn merged commit 0bce0a7 into sonic-net:master Mar 31, 2022

judyjoseph added the Included in 202111 Branch label Apr 4, 2022

judyjoseph pushed a commit that referenced this pull request Apr 4, 2022

Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic B… (

6933485

#10353) Why I did it To address #10342 (Yang validation fails when Buffer profiles are configured with "NULL" values)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic B…#10353

Allow NULL Buffer Profile in buffer pg/queue yang files for Dynamic B…#10353
neethajohn merged 3 commits intosonic-net:masterfrom
AmitKaushik7:buf_profile_NULL

AmitKaushik7 commented Mar 25, 2022

Uh oh!

dgsudharsan left a comment

Uh oh!

dgsudharsan commented Mar 25, 2022 •

edited by neethajohn

Loading

Uh oh!

stephenxs Mar 26, 2022

Uh oh!

dgsudharsan Mar 26, 2022

Uh oh!

stephenxs Mar 26, 2022 •

edited

Loading

Uh oh!

stephenxs commented Mar 26, 2022

Uh oh!

qiluo-msft commented Mar 31, 2022

Uh oh!

dgsudharsan commented Mar 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

AmitKaushik7 commented Mar 25, 2022

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

dgsudharsan left a comment

Choose a reason for hiding this comment

Uh oh!

dgsudharsan commented Mar 25, 2022 • edited by neethajohn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephenxs Mar 26, 2022

Choose a reason for hiding this comment

Uh oh!

dgsudharsan Mar 26, 2022

Choose a reason for hiding this comment

Uh oh!

stephenxs Mar 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenxs commented Mar 26, 2022

Uh oh!

qiluo-msft commented Mar 31, 2022

Uh oh!

dgsudharsan commented Mar 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dgsudharsan commented Mar 25, 2022 •

edited by neethajohn

Loading

stephenxs Mar 26, 2022 •

edited

Loading