[BFN] Fix exception when fwutil run without sudo

[taras-keryk]

Signed-off-by: Taras Keryk [email protected]

Why I did it

The previous implementaion of component.py expect fwutil run with sudo.
When fwutil run without sudo, there is exception:

 Traceback (most recent call last):
      File "/usr/local/bin/fwutil", line 5, in <module>
        from fwutil.main import cli
      File "/usr/local/lib/python3.9/dist-packages/fwutil/__init__.py", line 3, in <module>
        from . import main
      File "/usr/local/lib/python3.9/dist-packages/fwutil/main.py", line 40, in <module>
        pdp = PlatformDataProvider()
      File "/usr/local/lib/python3.9/dist-packages/fwutil/lib.py", line 159, in __init__
        self.__platform = Platform()
      File "/usr/local/lib/python3.9/dist-packages/sonic_platform/platform.py", line 21, in __init__
        self._chassis = Chassis()
      File "/usr/local/lib/python3.9/dist-packages/sonic_platform/chassis.py", line 48, in __init__
        self.__initialize_components()
      File "/usr/local/lib/python3.9/dist-packages/sonic_platform/chassis.py", line 136, in __initialize_components
        component = Components(index)
      File "/usr/local/lib/python3.9/dist-packages/sonic_platform/component.py", line 184, in __init__
        self.version = get_bios_version()
      File "/usr/local/lib/python3.9/dist-packages/sonic_platform/component.py", line 19, in get_bios_version
        return subprocess.check_output(['dmidecode', '-s', 'bios-version']).strip().decode()
      File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
        return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
      File "/usr/lib/python3.9/subprocess.py", line 505, in run
        with Popen(*popenargs, **kwargs) as process:
      File "/usr/lib/python3.9/subprocess.py", line 951, in __init__
        self._execute_child(args, executable, preexec_fn, close_fds,
      File "/usr/lib/python3.9/subprocess.py", line 1823, in _execute_child
        raise child_exception_type(errno_num, err_msg, err_filename)
    FileNotFoundError: [Errno 2] No such file or directory: 'dmidecode'

The previous implementaion of eeprom.py expect fwutil run with sudo.
When fwutil run without sudo, there is exception:

 Traceback (most recent call last):
    File "/usr/lib/python3.9/logging/config.py", line 564, in configure
    handler = self.configure_handler(handlers[name])
    File "/usr/lib/python3.9/logging/config.py", line 745, in configure_handler
    result = factory(**kwargs)
    File "/usr/lib/python3.9/logging/handlers.py", line 153, in init
    BaseRotatingHandler.init(self, filename, mode, encoding=encoding,
    File "/usr/lib/python3.9/logging/handlers.py", line 58, in init
    logging.FileHandler.init(self, filename, mode=mode,
    File "/usr/lib/python3.9/logging/init.py", line 1142, in init
    StreamHandler.init(self, self._open())
    File "/usr/lib/python3.9/logging/init.py", line 1171, in _open
    return open(self.baseFilename, self.mode, encoding=self.encoding,
    PermissionError: [Errno 13] Permission denied: '/var/log/platform.log'

The above exception was the direct cause of the following exception:

  Traceback (most recent call last):
    File "/usr/local/bin/fwutil", line 5, in
    from fwutil.main import cli
    File "/usr/local/lib/python3.9/dist-packages/fwutil/init.py", line 3, in
    from . import main
    File "/usr/local/lib/python3.9/dist-packages/fwutil/main.py", line 41, in
    pdp = PlatformDataProvider()
    File "/usr/local/lib/python3.9/dist-packages/fwutil/lib.py", line 162, in init
    self.chassis_component_map = self.__get_chassis_component_map()
    File "/usr/local/lib/python3.9/dist-packages/fwutil/lib.py", line 168, in __get_chassis_component_map
    chassis_name = self.__chassis.get_name()
    File "/usr/local/lib/python3.9/dist-packages/sonic_platform/chassis.py", line 146, in get_name
    return self._eeprom.modelstr()
    File "/usr/local/lib/python3.9/dist-packages/sonic_platform/chassis.py", line 54, in _eeprom
    self.__eeprom = Eeprom()
    File "/usr/local/lib/python3.9/dist-packages/sonic_platform/eeprom.py", line 50, in init
    logging.config.dictConfig(config_dict)
    File "/usr/lib/python3.9/logging/config.py", line 809, in dictConfig
    dictConfigClass(config).configure()
    File "/usr/lib/python3.9/logging/config.py", line 571, in configure
    raise ValueError('Unable to configure handler '
    ValueError: Unable to configure handler 'file'

How I did it

Modification call of dmidecode command.
Added modification of log files access attributes before file open operations.

How to verify it

Run manually 'fwutil' (without sudo)
New command output have no exception.

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[lgtm-com]

This pull request introduces 1 alert when merging df354f9 into 8f418bb - view on LGTM.com

new alerts:

• 1 for Unused import

[taras-keryk]

@prgeor please review

[taras-keryk]

@prgeor, can you please review