Rectify buffer_port_profile(ing/egr) yang files & related tests#10334
Closed
AmitKaushik7 wants to merge 1 commit intosonic-net:masterfrom
Closed
Rectify buffer_port_profile(ing/egr) yang files & related tests#10334AmitKaushik7 wants to merge 1 commit intosonic-net:masterfrom
AmitKaushik7 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
@Junchao-Mellanox Please help review. |
Collaborator
|
The old yang definition looks better. Could you please elaborate the reason to change it from list to string? If it is for the DPB issue, there is already a PR to handle it: #10291 |
Contributor
Author
|
I have not heard back on my comments last week in PR#9801, hence raised this PR. |
Collaborator
|
@AmitKaushik7 The suggestion from the yang community is to first initially fix it in yang infra and then slowly correct the offending configurations and not the yang model itself. Please sync up with @bandaru-viswanath |
Contributor
Author
|
Ok. closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Rectified Buffer Port Ingress/Egress Profile yang files derived from sonic/mgmt-cvl/testdata/schema from sonic-mgmt-common, used by mgmt-framework.
Updated BUFFER_PORT_INGRESS_PROFILE_LIST and BUFFER_PORT_EGRESS_PROFILE_LIST - Use Comma Separated string as profile list instead of List of Profile.
How I did it
Same change for BUFFER_PORT_INGRESS_PROFILE_LIST.
How to verify it
Rectified the test cases for ingress/egress buffer profile list.
test_yang_model.py 210 INFO BUFFER_PORT_INGRESS_PROFILE_LIST_CORRECT_PROFILE_VALUE no failure Passed
test_yang_model.py 210 INFO BUFFER_PORT_EGRESS_PROFILE_LIST_WRONG_PORT_VALUE pattern failure Passed
test_yang_model.py 210 INFO BUFFER_PORT_EGRESS_PROFILE_LIST_CORRECT_PROFILE_VALUE no failure Passed
test_yang_model.py 210 INFO BUFFER_PORT_EGRESS_PROFILE_LIST_MANDATORY_PROFILE_VALUE no profile Passed
test_yang_model.py 210 INFO BUFFER_PORT_INGRESS_PROFILE_LIST_MANDATORY_PROFILE_VALUE no profile Passed
test_yang_model.py 210 INFO BUFFER_PORT_INGRESS_PROFILE_LIST_WRONG_PORT_VALUE pattern failure Passed
Which release branch to backport (provide reason below if selected)
Description for the changelog
Rectify buffer_port_profile(ing/egr) yang files & update related test cases.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)