Skip to content

Adjusting Seastone's sfputil plugin to cope with new SfpUtil API.#1022

Merged
stcheng merged 2 commits intosonic-net:masterfrom
rodnymolina:sfputil_fix
Oct 10, 2017
Merged

Adjusting Seastone's sfputil plugin to cope with new SfpUtil API.#1022
stcheng merged 2 commits intosonic-net:masterfrom
rodnymolina:sfputil_fix

Conversation

@rodnymolina
Copy link
Contributor

@rodnymolina rodnymolina commented Oct 9, 2017

There are multiple platforms that need to be transitioned to the new SfpUtilBase interface -- I'm only taking care of Celestica-Seastone in this patch.

Adjusting Seastone's sfputil plugin to cope with new SfpUtil API.
fb9f11a 
There are multiple platforms that need to be transitioned to the new
SfpUtilBase interface -- I'm only taking care of Celestica-Seastone in this patch.
stcheng
stcheng reviewed Oct 10, 2017
View reviewed changes
device/celestica/x86_64-cel_seastone-r0/plugins/sfputil.py Outdated
PORTS_IN_BLOCK = 32

port_to_eeprom_mapping = {}
# EEPROM_OFFSET = 20
Copy link
Contributor

@stcheng stcheng Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need this line?

Copy link
Contributor Author

@rodnymolina rodnymolina Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, forgot to remove it, will send another patch right away.

@stcheng stcheng merged commit f681fd1 into sonic-net:master Oct 10, 2017
@rodnymolina rodnymolina mentioned this pull request Oct 12, 2017
Closed
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Aug 5, 2020
@lguohan
[submodule]: update sonic-utilities
b1f2a4e 
* 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (sonic-net#1015) (HEAD, origin/master, origin/HEAD) [lguohan]
* c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (sonic-net#1023) [lguohan]
* dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (sonic-net#1016) [Arun Saravanan Balachandran]
* 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (sonic-net#1022) [lguohan]
* c0c3cce 2020-07-30 | [config/config_mgmt.py]: Fix typo and enable test for tablesWithOutYang() (sonic-net#1012) [Praveen Chaudhary]
* c6c5be1 2020-07-30 | [show] Fix for 'trunk' PortChannel reported as 'routed' port (sonic-net#1002) [shlomibitton]
* ef9ac2a 2020-07-29 | importing json needed for DPB CLI (sonic-net#1010) [Sangita Maity]
* aa1b072 2020-07-23 | [config] Add Initial draft of Breakout Mode subcommand (sonic-net#766) [Sangita Maity]
lguohan added a commit that referenced this pull request Aug 5, 2020
@lguohan
[build]: combine feature and container feature table (#5081)
082c26a 
1. remove container feature table
2. do not generate feature entry if the feature is not included
   in the image
3. rename ENABLE_* to INCLUDE_* for better clarity
4. rename feature status to feature state
5. [submodule]: update sonic-utilities

* 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (#1015) (HEAD, origin/master, origin/HEAD) [lguohan]
* c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (#1023) [lguohan]
* dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (#1016) [Arun Saravanan Balachandran]
* 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (#1022) [lguohan]

Signed-off-by: Guohan Lu <[email protected]>
abdosi pushed a commit that referenced this pull request Aug 9, 2020
@lguohan @abdosi
[build]: combine feature and container feature table (#5081)
78c8038 
1. remove container feature table
2. do not generate feature entry if the feature is not included
   in the image
3. rename ENABLE_* to INCLUDE_* for better clarity
4. rename feature status to feature state
5. [submodule]: update sonic-utilities

* 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (#1015) (HEAD, origin/master, origin/HEAD) [lguohan]
* c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (#1023) [lguohan]
* dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (#1016) [Arun Saravanan Balachandran]
* 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (#1022) [lguohan]

Signed-off-by: Guohan Lu <[email protected]>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@lguohan @santhosh-kt
[build]: combine feature and container feature table (sonic-net#5081)
70732f3 
1. remove container feature table
2. do not generate feature entry if the feature is not included
   in the image
3. rename ENABLE_* to INCLUDE_* for better clarity
4. rename feature status to feature state
5. [submodule]: update sonic-utilities

* 9700e45 2020-08-03 | [show/config]: combine feature and container feature cli (sonic-net#1015) (HEAD, origin/master, origin/HEAD) [lguohan]
* c9d3550 2020-08-03 | [tests]: fix drops_group_test failure on second run (sonic-net#1023) [lguohan]
* dfaae69 2020-08-03 | [lldpshow]: Fix input device is not a TTY error (sonic-net#1016) [Arun Saravanan Balachandran]
* 216688e 2020-08-02 | [tests]: rename sonic-utilitie-tests to tests (sonic-net#1022) [lguohan]

Signed-off-by: Guohan Lu <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@lguohan
[tests]: rename sonic-utilitie-tests to tests (sonic-net#1022)
216688e
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Jul 22, 2022
@kcudnik
[syncd] Fix comparison logic for new transferred objects (sonic-net#1022
4b2638c 
)

For created objects like buffer pool or buffer profile
those are not on the switch, but they were treated as such
and transferred to temporary view during comparison logic
causing to duplicate objects on temporary view
mssonicbld added a commit that referenced this pull request Jun 6, 2025
@mssonicbld
[submodule] Update submodule sonic-swss-common to the latest HEAD aut…
7a61cc3 
…omatically (#22865)

#### Why I did it
src/sonic-swss-common
```
* 7312b05 - (HEAD -> 202505, origin/202505) [schema] Add table definitions for bgp_session_tracker and link_state_tracker (#1024) (4 hours ago) [mssonicbld]
* 56c5919 - [build] deprecate ubuntu 20.04 agent pool. (#1022) (18 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
vmittal-msft pushed a commit to vmittal-msft/sonic-buildimage that referenced this pull request Oct 20, 2025
@arlakshm
[Nokia][New Platform][DeviceData] Nokia adds new platforms support (X…
c134bfb 
…3B platform) (sonic-net#21710) (sonic-net#1022)

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
Nokia adds X3B platform support:
Platform: x86_64-nokia_ixr7250_x3b-r0 Hwsku: Nokia-IXR7250-X3B

##### Work item tracking
- Microsoft ADO
**[32398643](https://msazure.visualstudio.com/One/_workitems/edit/32398643)**:

#### How I did it
Add new platform Nokia-IXR7250-X3B. platform string:
x86_64-nokia_ixr7250_x3b-r0. Hwsku: Nokia-IXR7250-X3B. Nokia-IXR7250-X3B
support VoQ T2 feature. Follow the existing multi-asic chassis design,
database-chassis is required to be created and support on the PizzaBox.
It means that chassisdb.conf will be defined and used in the platform.
To support the database-chassis, docker0 (240.127.1.1) will be used for
the redis-chassis.server. Key file platform_env.conf will be defined
without "supervisor=1" definition to differentiate the x3b and Chassis
Supervisor. This Platform support requires PR sonic-net#21709

#### How to verify it
Install and run the image on X3B platform and verify all features
<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stcheng stcheng stcheng left review comments

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement ➕

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rodnymolina @stcheng @jleveque