Install the allure-pytest package globally in sonic-mgmt docker#10216
Merged
wangxin merged 1 commit intosonic-net:masterfrom Mar 12, 2022
Merged
Install the allure-pytest package globally in sonic-mgmt docker#10216wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Why I did it User install position caused the fail on nightly test How I did it Change the install position globally How to verify it Import allure in docker/ run nightly test
wangxin
approved these changes
Mar 11, 2022
6 tasks
This was referenced Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This fix is to address issue: sonic-net/sonic-mgmt#5280
In the sonic-mgmt Dockerfile, python package
allure-pytestis installed afterENV USER $user.Consequently the package is installed to path
/home/$user/.localand is only available to the $useraccount. If we use root account in sonic-mgmt docker container to run tests, any script importing
the
allurepackage will fail withImportError. We need to install theallure-pytestpackage to globaldirectory instead of user local directory.
How I did it
Update the sonic-mgmt Dockerfile to ensure that the
allure-pytestpackage is installed to global directoryHow to verify it
allure-pytestpackage. NoImportErroris raised.Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)