[PINS] update sonic-p4rt docker to bullseye#10182
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Mar 24, 2022
Merged
[PINS] update sonic-p4rt docker to bullseye#10182qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
|
@bocon13 @donNewtonAlpha For Info |
Contributor
|
Thanks @rhalstea for working on this! Here's the fix on the packaging side: sonic-net/sonic-pins#4 |
Contributor
|
@rhalstea @bocon13 I faced the same build error when I build libsairedis locally, how can I fix this, thanks!: |
Contributor
Author
|
@pettershao-ragilenetworks I haven't looked into the siaredis issue. This fix is addressing the incompatibilities in the p4rt docker. Have you tried the suggestions in this comment: #9885 (comment) |
lguohan
approved these changes
Mar 23, 2022
Contributor
Author
|
Thanks @lguohan, Is there anything else needed before we merge this? |
qiluo-msft
approved these changes
Mar 24, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
SONiC is migrating to bullseye. This will update the sonic-pins container to bullseye.
How I did it
The sonic-pins code isn't dependent on any architecture so it will already build successfully for bullseye. This PR updates the docker to use bullseye.
How to verify it
Today we cannot build the docker-sonic-p4rt.gz target (e.g. Issue #9885). With this change the docker will build successfully. The P4RT executable will not run, because of a missing runtime library, libgmpxx, which I'll address in a followup PR.
Which release branch to backport (provide reason below if selected)
None.
Description for the changelog
Update docker-sonic-p4rt.gz target to build with Bullseye instead of Buster.
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)