Skip to content

[Build]: Fix installing dpkg packages in parallel issue#10175

Merged
xumia merged 4 commits intosonic-net:masterfrom
xumia:fix-apt-install-conflict
Mar 14, 2022
Merged

[Build]: Fix installing dpkg packages in parallel issue#10175
xumia merged 4 commits intosonic-net:masterfrom
xumia:fix-apt-install-conflict

Conversation

@xumia
Copy link
Collaborator

@xumia xumia commented Mar 8, 2022

Why I did it

Fix the debian packages installing in parallel issue.
Add apt hook command to support apt to print no version control info.

How I did it

Add a file lock, it can block the apt/apt-get installation for 10 min in max if another apt/apt-get installation command is running. It only has effect on the build time.

Clarify the feature to the lock in slave.mk:
Currently, we already has a lock in the slave.mk, it has no effect when installing the package inside of the makefile. Comparing the method, the method in the pr is more general, take effect when using the command apt/apt-get.
And it is not as a replacement for the debian installation lock in the slave.mk, another feature of the lock in slave.mk is to block some of the conflict packages installation, so make the conflict targets not building in the same time.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia requested a review from liushilongbuaa March 8, 2022 04:55
@xumia xumia requested a review from qiluo-msft March 11, 2022 01:24
@xumia xumia marked this pull request as ready for review March 11, 2022 01:25
@xumia xumia requested a review from lguohan as a code owner March 11, 2022 01:25
@xumia xumia merged commit 7178c66 into sonic-net:master Mar 14, 2022
@xumia xumia deleted the fix-apt-install-conflict branch March 14, 2022 03:20
@qiluo-msft
Copy link
Collaborator

Could you explain the original problem? What is the error message?
I am confused at dpkg in title, seem you are only fixing apt or apt-get.

qiluo-msft pushed a commit that referenced this pull request Mar 16, 2022
Why I did it
Fix the debian packages installing in parallel issue.
Add apt hook command to support apt to print no version control info.
judyjoseph pushed a commit that referenced this pull request Mar 20, 2022
Why I did it
Fix the debian packages installing in parallel issue.
Add apt hook command to support apt to print no version control info.
xumia added a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 21, 2022
)

Why I did it
Fix the debian packages installing in parallel issue.
Add apt hook command to support apt to print no version control info.
xumia added a commit that referenced this pull request Apr 7, 2022
Why I did it
Fix the debian packages installing in parallel issue.
Add apt hook command to support apt to print no version control info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants